Refactor admin UI structure #244
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
local-it/mitgliederverwaltung!244
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refactor-admin-settings-ui"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description of the implemented changes
The changes were:
Fixes #212
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
11dfde921a95e147bc79WIP: Refactor admin UI structureto Refactor admin UI structure95e147bc79b34d5ec99fb34d5ec99fae179703dbae179703db483854ea65483854ea65ba5fc34d80Looks nice ! :)
@ -0,0 +16,4 @@def render(assigns) do~H"""<div id={@id}><.header>I think we should avoid using th eheader component in components that we embed somewhere, because it renders as h1, and there can always only be one h1 tag per page. But we can have a seperate issue to check the heading for all pages at once I think
@ -0,0 +78,4 @@</:action><:action :let={{_id, custom_field}}><.link phx-click={JS.push("prepare_delete", value: %{id: custom_field.id}, target: @myself)}>What's the reason to use JS.push here? :)
@ -0,0 +85,4 @@</.table><%!-- Delete Confirmation Modal --%><dialog :if={@show_delete_modal} id="delete-custom-field-modal" class="modal modal-open">Maybe for later we can have an issue to move dialogs to core components to reuse them?