local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Refactor admin UI structure #244

Merged
carla merged 4 commits from refactor-admin-settings-ui into main 2025-12-03 18:00:54 +01:00
Conversation 1 Commits 4 Files changed 15 +727 -568
rafael commented 2025-12-03 10:28:33 +01:00
Collaborator
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Fixes #212

What has been changed?

  • Move custom fields settings into a section on the admin UI page

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [ ] New Feature - [ ] Breaking Change - [x] Refactoring Fixes #212 ## What has been changed? - Move custom fields settings into a section on the admin UI page ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [x] New elements are properly defined with html-tags - [x] Colour contrast follows WCAG criteria - [x] Aria labels are added when needed - [x] Everything is accessible by keyboard - [x] Tab-Order is comprehensible - [x] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
rafael self-assigned this 2025-12-03 10:28:33 +01:00
rafael added 1 commit 2025-12-03 10:28:35 +01:00
Move custom fields to global admin settings
Some checks failed
continuous-integration/drone/push Build is failing
Details
11dfde921a
rafael force-pushed refactor-admin-settings-ui from 11dfde921a to 95e147bc79 2025-12-03 13:27:07 +01:00 Compare
rafael changed title from WIP: Refactor admin UI structure to Refactor admin UI structure 2025-12-03 14:24:51 +01:00
rafael force-pushed refactor-admin-settings-ui from 95e147bc79 to b34d5ec99f 2025-12-03 14:31:40 +01:00 Compare
rafael force-pushed refactor-admin-settings-ui from b34d5ec99f to ae179703db 2025-12-03 14:33:38 +01:00 Compare
requested review from carla 2025-12-03 15:09:28 +01:00
carla added this to the Sprint 9: 20.11 - 11.12 project 2025-12-03 15:09:35 +01:00
rafael force-pushed refactor-admin-settings-ui from ae179703db to 483854ea65 2025-12-03 15:15:47 +01:00 Compare
rafael force-pushed refactor-admin-settings-ui from 483854ea65 to ba5fc34d80 2025-12-03 16:32:50 +01:00 Compare
moritz removed this from the Sprint 9: 20.11 - 11.12 project 2025-12-03 17:14:05 +01:00
carla approved these changes 2025-12-03 17:28:53 +01:00
carla left a comment
Owner
Copy link

Looks nice ! :)

Looks nice ! :)
lib/mv_web/live/custom_field_live/index_component.ex Outdated
@ -0,0 +16,4 @@
def render(assigns) do
~H"""
<div id={@id}>
<.header>
carla commented 2025-12-03 15:47:28 +01:00
Owner
Copy link

I think we should avoid using th eheader component in components that we embed somewhere, because it renders as h1, and there can always only be one h1 tag per page. But we can have a seperate issue to check the heading for all pages at once I think

I think we should avoid using th eheader component in components that we embed somewhere, because it renders as h1, and there can always only be one h1 tag per page. But we can have a seperate issue to check the heading for all pages at once I think
lib/mv_web/live/custom_field_live/index_component.ex Outdated
@ -0,0 +78,4 @@
</:action>
<:action :let={{_id, custom_field}}>
<.link phx-click={JS.push("prepare_delete", value: %{id: custom_field.id}, target: @myself)}>
carla commented 2025-12-03 17:24:11 +01:00
Owner
Copy link

What's the reason to use JS.push here? :)

What's the reason to use JS.push here? :)
lib/mv_web/live/custom_field_live/index_component.ex Outdated
@ -0,0 +85,4 @@
</.table>
<%!-- Delete Confirmation Modal --%>
<dialog :if={@show_delete_modal} id="delete-custom-field-modal" class="modal modal-open">
carla commented 2025-12-03 17:26:30 +01:00
Owner
Copy link

Maybe for later we can have an issue to move dialogs to core components to reuse them?

Maybe for later we can have an issue to move dialogs to core components to reuse them?
carla added 1 commit 2025-12-03 17:29:13 +01:00
Merge branch 'main' into refactor-admin-settings-ui
Some checks failed
continuous-integration/drone/push Build is failing
Details
188a6f667c
carla added 1 commit 2025-12-03 17:44:10 +01:00
formatting
All checks were successful
continuous-integration/drone/push Build is passing
Details
8ce89a7227
carla merged commit a68a15be6a into main 2025-12-03 18:00:54 +01:00
carla deleted branch refactor-admin-settings-ui 2025-12-03 18:00:55 +01:00
carla added this to the Sprint 9: 20.11 - 11.12 project 2025-12-03 18:01:18 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
carla
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Sprint 9: 20.11 - 11.12
Assignees
Clear assignees
No assignees
rafael
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#244
No description provided.
Delete branch "refactor-admin-settings-ui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?