local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

UX - Avoid opening member by clicking the checkbox closes #233 #250

Open
moritz wants to merge 2 commits from feature/223_member_checkbox into main
pull from: feature/223_member_checkbox
merge into: local-it:main
Conversation 4 Commits 2 Files changed 7 +87 -96
moritz commented 2025-12-03 14:36:07 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [x] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
moritz self-assigned this 2025-12-03 14:36:07 +01:00
moritz added 2 commits 2025-12-03 14:36:08 +01:00 
- Add col_click slot attribute to table component that overrides row_click
- Clicking anywhere in the checkbox column now toggles the checkbox
- Clicking other columns still navigates to member details

Closes #223
requested review from rafael 2025-12-03 16:37:58 +01:00
rafael reviewed 2025-12-03 16:43:12 +01:00
lib/mv_web/components/core_components.ex
@ -396,0 +396,4 @@
(col[:col_click] && col[:col_click].(@row_item.(row))) ||
(@row_click && @row_click.(row))
}
class={(col[:col_click] || @row_click) && "hover:cursor-pointer"}
rafael commented 2025-12-03 16:43:12 +01:00
Collaborator
Copy link

Seems like this is a tiny bit off at the moment - there's a small area below the checkbox where the cursor changes from the "pointer" image to the normal cursor, which is a bit confusing

Seems like this is a tiny bit off at the moment - there's a small area below the checkbox where the cursor changes from the "pointer" image to the normal cursor, which is a bit confusing
rafael reviewed 2025-12-03 16:44:45 +01:00
rafael reviewed 2025-12-03 16:47:06 +01:00
rafael reviewed 2025-12-03 16:47:22 +01:00
This pull request has changes conflicting with the target branch.
  • lib/mv_web/components/core_components.ex
  • priv/gettext/de/LC_MESSAGES/default.po
  • priv/gettext/default.pot
  • priv/gettext/en/LC_MESSAGES/default.po
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/223_member_checkbox:feature/223_member_checkbox
git checkout feature/223_member_checkbox

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff feature/223_member_checkbox
git checkout feature/223_member_checkbox
git rebase main
git checkout main
git merge --ff-only feature/223_member_checkbox
git checkout feature/223_member_checkbox
git rebase main
git checkout main
git merge --no-ff feature/223_member_checkbox
git checkout main
git merge --squash feature/223_member_checkbox
git checkout main
git merge --ff-only feature/223_member_checkbox
git checkout main
git merge feature/223_member_checkbox
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
rafael
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#250
No description provided.
Delete branch "feature/223_member_checkbox"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?