local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 61 Pull requests 12 Projects 1 Releases Packages 1 Activity Actions

Membership Fee Type Resource & Settings #292

Open
moritz wants to merge 11 commits from feature/278_membership_fee_settings into feature/277_cycle_generation
pull from: feature/278_membership_fee_settings
merge into: local-it:feature/277_cycle_generation
Conversation 0 Commits 11 Files changed 15 +1274 -658
moritz commented 2025-12-12 18:20:47 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [ ] No new technical depths - [ ] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [ ] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
moritz self-assigned this 2025-12-12 18:20:47 +01:00
moritz added 5 commits 2025-12-12 18:20:48 +01:00 
- Add interval immutability and deletion prevention validations
- Add settings validation for default_membership_fee_type_id
- Create MembershipFeeSettingsLive for admin UI with form handling
- Add comprehensive test coverage (unit, integration, settings)
fix: improve accessibility - WCAG 2 AA contrast and select label
Some checks failed
continuous-integration/drone/push Build is failing
Details
5bdd769699
refactor: use Enum.map_join instead of Enum.map |> Enum.join
All checks were successful
continuous-integration/drone/push Build is passing
Details
af7ae2b722
moritz added 6 commits 2025-12-12 19:10:57 +01:00
feat: add 4 example membership fee types to seed script
All checks were successful
continuous-integration/drone/push Build is passing
Details
f39fd49af3
All checks were successful
continuous-integration/drone/push Build is passing
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/278_membership_fee_settings:feature/278_membership_fee_settings
git checkout feature/278_membership_fee_settings

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout feature/277_cycle_generation
git merge --no-ff feature/278_membership_fee_settings
git checkout feature/278_membership_fee_settings
git rebase feature/277_cycle_generation
git checkout feature/277_cycle_generation
git merge --ff-only feature/278_membership_fee_settings
git checkout feature/278_membership_fee_settings
git rebase feature/277_cycle_generation
git checkout feature/277_cycle_generation
git merge --no-ff feature/278_membership_fee_settings
git checkout feature/277_cycle_generation
git merge --squash feature/278_membership_fee_settings
git checkout feature/277_cycle_generation
git merge --ff-only feature/278_membership_fee_settings
git checkout feature/277_cycle_generation
git merge feature/278_membership_fee_settings
git push origin feature/277_cycle_generation
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
moritz
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#292
No description provided.
Delete branch "feature/278_membership_fee_settings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?