Implements settings for member fields closes #223

carla commented

2025-12-16 17:58:05 +01:00

Owner

Description of the implemented changes

The changes were:

Bugfixing
New Feature
Breaking Change
Refactoring

What has been changed?

Definition of Done

Code Quality

No new technical depths
Linting passed
Documentation is added were needed

Accessibility

New elements are properly defined with html-tags
Colour contrast follows WCAG criteria
Aria labels are added when needed
Everything is accessible by keyboard
Tab-Order is comprehensible
All interactive elements have a visible focus

Testing

Tests for new code are written
All tests pass
axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring  ## What has been changed?  ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [x] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [x] Aria labels are added when needed - [x] Everything is accessible by keyboard - [x] Tab-Order is comprehensible - [x] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes

carla added 8 commits 2025-12-16 17:58:06 +01:00

test: added tests eea3f28cc5

test: adds tests 756d99dcc8

feat: adds memberdata component for settings 3d81461fbe

feat: adds required column to custom field settings e088123fb9

chore: updated translation

continuous-integration/drone/push Build is failing

Details

18c082a893

feat: adds form for member fields 5fa0b48acc

style: combines member and custom fields in settings c88f805b6e

chore: updates translation

continuous-integration/drone/push Build is failing

Details

e2c5971daf

carla commented

2025-12-16 17:59:22 +01:00

Author

Owner

@simon or @moritz maybe one of you can check the UI. It is not ready yet but there is the possibility now to edit member fields (despite changing name or required for mail) like for custom fields. We can talk about it on thursday then maybe.

requested reviews from moritz, simon

2026-01-02 13:55:13 +01:00

moritz commented

2026-01-06 16:22:40 +01:00

Owner

I can't log in with rauthy anymore:

no function clause matching in MvWeb.AuthController.handle_rauthy_failure/2

The UI looks good for me.
A small thing: the exit date is not shown in the members view.

I can't log in with rauthy anymore: ``` no function clause matching in MvWeb.AuthController.handle_rauthy_failure/2 ``` The UI looks good for me. A small thing: the exit date is not shown in the members view.

carla commented

2026-01-06 16:31:44 +01:00

Author

Owner

@moritz wrote in #300 (comment):

I can't log in with rauthy anymore:
no function clause matching in MvWeb.AuthController.handle_rauthy_failure/2
The UI looks good for me. A small thing: the exit date is not shown in the members view.

Thanks for having a look!
I will check Rauthy and regarding exit date: I will check...but is it actually useful to have it here? Do we want to show also members here who are not part of the association anymore?

@moritz wrote in https://git.local-it.org/local-it/mitgliederverwaltung/pulls/300#issuecomment-16321: > I can't log in with rauthy anymore: > > ```text > no function clause matching in MvWeb.AuthController.handle_rauthy_failure/2 > ``` > > The UI looks good for me. A small thing: the exit date is not shown in the members view. Thanks for having a look! I will check Rauthy and regarding exit date: I will check...but is it actually useful to have it here? Do we want to show also members here who are not part of the association anymore?

moritz commented

2026-01-06 19:25:45 +01:00

Owner

@carla wrote in #300 (comment):

Do we want to show also members here who are not part of the association anymore?

I think this should be handled by filters like (show only active member / show fomer member)
A good default for the exit date is to hide it, but there should be the possibility to show it if required.

@carla wrote in https://git.local-it.org/local-it/mitgliederverwaltung/pulls/300#issuecomment-16322: > Do we want to show also members here who are not part of the association anymore? I think this should be handled by filters like (show only active member / show fomer member) A good default for the exit date is to hide it, but there should be the possibility to show it if required.

👍 1

carla commented

2026-01-07 11:17:04 +01:00

Author

Owner

@moritz wrote in #300 (comment):

@carla wrote in #300 (comment):

Do we want to show also members here who are not part of the association anymore?

I think this should be handled by filters like (show only active member / show fomer member) A good default for the exit date is to hide it, but there should be the possibility to show it if required.

I added an issue to add the filters:#328

@moritz wrote in https://git.local-it.org/local-it/mitgliederverwaltung/pulls/300#issuecomment-16338: > @carla wrote in #300 (comment): > > > Do we want to show also members here who are not part of the association anymore? > > I think this should be handled by filters like (show only active member / show fomer member) A good default for the exit date is to hide it, but there should be the possibility to show it if required. I added an issue to add the filters:https://git.local-it.org/local-it/mitgliederverwaltung/issues/328

carla added 2 commits 2026-01-07 11:43:06 +01:00

Merge branch 'main' into feature/223_memberfields_settings 909d4af2a2

Merge branch 'main' into feature/223_memberfields_settings

continuous-integration/drone/push Build is failing

Details

df8c6a1854

carla added 13 commits 2026-01-08 11:41:36 +01:00

fix: cath all rauthy errors cbe05c5ca8

fix: exit date as default hidden column 38d106a69e

feat: show only edit or list view in settings 4a6e7cf51a

fix tests and linting 36776f8e28

refactor: extract helper modules to remove code duplication 9af7381843