local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 66 Pull requests 7 Projects 1 Releases Packages 1 Activity Actions

WIP: Implements settings for member fields closes #223 #300

Draft
carla wants to merge 8 commits from feature/223_memberfields_settings into main
pull from: feature/223_memberfields_settings
merge into: local-it:main
Conversation 1 Commits 8 Files changed 10 +1530 -139
carla commented 2025-12-16 17:58:05 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [ ] No new technical depths - [ ] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [ ] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
carla added 8 commits 2025-12-16 17:58:06 +01:00
chore: updated translation
Some checks failed
continuous-integration/drone/push Build is failing
Details
18c082a893
chore: updates translation
Some checks failed
continuous-integration/drone/push Build is failing
Details
e2c5971daf
carla commented 2025-12-16 17:59:22 +01:00
Author
Owner
Copy link

@simon or @moritz maybe one of you can check the UI. It is not ready yet but there is the possibility now to edit member fields (despite changing name or required for mail) like for custom fields. We can talk about it on thursday then maybe.

@simon or @moritz maybe one of you can check the UI. It is not ready yet but there is the possibility now to edit member fields (despite changing name or required for mail) like for custom fields. We can talk about it on thursday then maybe.
Some checks failed
continuous-integration/drone/push Build is failing
Details
This pull request has changes conflicting with the target branch.
  • lib/mv_web/live/custom_field_live/index_component.ex
  • priv/gettext/de/LC_MESSAGES/default.po
  • priv/gettext/default.pot
  • priv/gettext/en/LC_MESSAGES/default.po
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/223_memberfields_settings:feature/223_memberfields_settings
git checkout feature/223_memberfields_settings

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff feature/223_memberfields_settings
git checkout feature/223_memberfields_settings
git rebase main
git checkout main
git merge --ff-only feature/223_memberfields_settings
git checkout feature/223_memberfields_settings
git rebase main
git checkout main
git merge --no-ff feature/223_memberfields_settings
git checkout main
git merge --squash feature/223_memberfields_settings
git checkout main
git merge --ff-only feature/223_memberfields_settings
git checkout main
git merge feature/223_memberfields_settings
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
optional

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#300
No description provided.
Delete branch "feature/223_memberfields_settings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?