local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 66 Pull requests 7 Projects 1 Releases Packages 1 Activity Actions

Implements validation for required custom fields closes #274 #301

Open
carla wants to merge 2 commits from bugfix/274_required_custom_fields into main
pull from: bugfix/274_required_custom_fields
merge into: local-it:main
Conversation 0 Commits 2 Files changed 3 +605
carla commented 2025-12-17 13:32:15 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [x] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
carla added 1 commit 2025-12-17 13:32:16 +01:00
fix: add validation for required custom fields
Some checks failed
continuous-integration/drone/push Build is failing
Details
bbc094daaa
carla added 1 commit 2025-12-17 14:34:18 +01:00
test: updated
All checks were successful
continuous-integration/drone/push Build is passing
Details
6084827c73
All checks were successful
continuous-integration/drone/push Build is passing
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin bugfix/274_required_custom_fields:bugfix/274_required_custom_fields
git checkout bugfix/274_required_custom_fields

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff bugfix/274_required_custom_fields
git checkout bugfix/274_required_custom_fields
git rebase main
git checkout main
git merge --ff-only bugfix/274_required_custom_fields
git checkout bugfix/274_required_custom_fields
git rebase main
git checkout main
git merge --no-ff bugfix/274_required_custom_fields
git checkout main
git merge --squash bugfix/274_required_custom_fields
git checkout main
git merge --ff-only bugfix/274_required_custom_fields
git checkout main
git merge bugfix/274_required_custom_fields
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
optional

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#301
No description provided.
Delete branch "bugfix/274_required_custom_fields"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?