Fix email sync (user->member) when changing password and email

moritz commented

2026-01-27 16:15:53 +01:00

Owner

Description of the implemented changes

The changes were:

Bugfixing
New Feature
Breaking Change
Refactoring

What has been changed?

Definition of Done

Code Quality

No new technical depths
Linting passed
Documentation is added were needed

Accessibility

New elements are properly defined with html-tags
Colour contrast follows WCAG criteria
Aria labels are added when needed
Everything is accessible by keyboard
Tab-Order is comprehensible
All interactive elements have a visible focus

Testing

Tests for new code are written
All tests pass
axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [x] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring  ## What has been changed?  ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes

moritz added the

bug

label 2026-01-27 16:15:53 +01:00

moritz self-assigned this 2026-01-27 16:15:53 +01:00

moritz added 6 commits 2026-01-27 16:15:54 +01:00

Ensure system actor user exists via migration 63377717e4

Creates user system@mila.local with Admin role if missing. Idempotent;
guarantees system actor in production without relying on seeds.

Prevent deletion of system actor user 55f322a09b

Add destroy validation and explicit destroy action (primary, require_atomic? false).
Validation blocks destroy when email == SystemActor.system_user_email().

Hide system actor from user list and block show/edit 56bf411756

Index: filter out SystemActor.system_user_email() in query. Show/Form:
redirect to /users with flash when viewing or editing system actor user.
Index format_error: handle Ash errors without :message field.

Add tests for system actor protection and hiding 86c1ab8462

Index: system actor not in list, destroy returns Ash.Error.Invalid. Show/Form:
redirect to /users when viewing or editing system actor user.

Add gettext strings for system actor show/edit redirect messages

continuous-integration/drone/push Build is failing

Details

b5b2317d69

German: Dieser Benutzer kann nicht angezeigt/bearbeitet werden.

Sync user email to member when changing password (admin_set_password)

continuous-integration/drone/push Build is passing

Details

ae6e26e487

Add SyncUserEmailToMember change to admin_set_password so email+password
updates in the user form sync the new email to the linked member.

moritz added this to the Sprint 11: 08.01-29.01 project 2026-01-27 16:15:56 +01:00

moritz force-pushed fix/email_sync from ae6e26e487 to 2b4e1e3963

2026-01-27 17:59:11 +01:00

Compare

moritz merged commit 4e8e697490 into main

2026-01-27 18:08:07 +01:00

moritz deleted branch fix/email_sync

2026-01-27 18:08:08 +01:00

moritz referenced this pull request from a commit

2026-01-27 18:08:09 +01:00

Merge pull request 'Fix email sync (user->member) when changing password and email' (#380) from fix/email_sync into main

Rows
Columns

Fix email sync (user->member) when changing password and email #380