local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 59 Pull requests 6 Projects 2 Releases Packages 1 Activity Actions

[Bug] OIDC: use Application config :oidc from runtime.exs for client secret in prod #456

Merged
moritz merged 1 commit from fix/oidc into main 2026-03-02 15:18:10 +01:00
Conversation 0 Commits 1 Files changed 1 +22 -3
moritz commented 2026-03-02 15:08:09 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring <!--- Describe the goal of the PR in a few words --> ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [ ] No new technical depths - [ ] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [ ] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
moritz self-assigned this 2026-03-02 15:08:09 +01:00
moritz added 1 commit 2026-03-02 15:08:10 +01:00
OIDC: use Application config :oidc from runtime.exs for client secret in prod
Some checks failed
continuous-integration/drone/push Build is failing
Details
502c494e84
moritz added this to the Sprint 13: 19.02-26.02 project 2026-03-02 15:08:11 +01:00
moritz force-pushed fix/oidc from 502c494e84 to 3187d408c5 2026-03-02 15:09:43 +01:00 Compare
moritz merged commit f3be6ee198 into main 2026-03-02 15:18:10 +01:00
moritz deleted branch fix/oidc 2026-03-02 15:18:10 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
optional

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Sprint 13: 19.02-26.02
Assignees
Clear assignees
No assignees
moritz
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#456
No description provided.
Delete branch "fix/oidc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?