feat: Add member fee type filter to member list

moritz commented

2026-03-04 21:21:00 +01:00

Owner

Description of the implemented changes

The changes were:

Bugfixing
New Feature
Breaking Change
Refactoring

Add a filter by membership fee type on the member list and refactor the filter component to satisfy Credo complexity rules.

What has been changed?

Member list (Index): Load membership fee types, add fee_type_filters state and URL params (fee_type_<uuid>=in|not_in), apply fee type filters in load_members, and extend build_query_params / reset_all_filters / handle_params for fee type filters.
MemberFilterComponent: New “Fee types” section (one row per fee type with All/Yes/No), new assigns and events (fee_type_filter_changed), and reset logic including fee type filters. Refactored handle_event("update_filters", ...) by extracting parse_payment_filter, parse_prefix_filters, parse_custom_boolean_filters, and dispatch_* helpers to reduce cyclomatic complexity below Credo’s limit.
Index template: Pass fee_types and fee_type_filters into the filter component.
Gettext: Ran mix gettext.extract and mix gettext.merge so new strings (e.g. “Fee types”) are in the POT and locale files.

Definition of Done

Code Quality

No new technical depths
Linting passed
Documentation is added where needed

Accessibility

New elements are properly defined with html-tags
Colour contrast follows WCAG criteria
Aria labels are added when needed
Everything is accessible by keyboard
Tab-Order is comprehensible
All interactive elements have a visible focus

Testing

Tests for new code are written
All tests pass
axe-core dev tools show no critical or major issues

Additional Notes

Fee type filter reuses the same pattern as the existing group filter (fieldset + legend, join buttons All/Yes/No, same styling and focus handling). If the group filter is already considered accessible and tested, the same checklist items likely apply to the new fee type block.
The refactor in MemberFilterComponent only restructures code (parse/dispatch helpers); behaviour and UI are unchanged.

## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [x] Refactoring Add a filter by membership fee type on the member list and refactor the filter component to satisfy Credo complexity rules. ## What has been changed? - **Member list (Index):** Load membership fee types, add `fee_type_filters` state and URL params (`fee_type_<uuid>=in|not_in`), apply fee type filters in `load_members`, and extend `build_query_params` / `reset_all_filters` / `handle_params` for fee type filters. - **MemberFilterComponent:** New “Fee types” section (one row per fee type with All/Yes/No), new assigns and events (`fee_type_filter_changed`), and reset logic including fee type filters. Refactored `handle_event("update_filters", ...)` by extracting `parse_payment_filter`, `parse_prefix_filters`, `parse_custom_boolean_filters`, and `dispatch_*` helpers to reduce cyclomatic complexity below Credo’s limit. - **Index template:** Pass `fee_types` and `fee_type_filters` into the filter component. - **Gettext:** Ran `mix gettext.extract` and `mix gettext.merge` so new strings (e.g. “Fee types”) are in the POT and locale files. ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added where needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes - Fee type filter reuses the same pattern as the existing group filter (fieldset + legend, join buttons All/Yes/No, same styling and focus handling). If the group filter is already considered accessible and tested, the same checklist items likely apply to the new fee type block. - The refactor in `MemberFilterComponent` only restructures code (parse/dispatch helpers); behaviour and UI are unchanged.

moritz self-assigned this

2026-03-04 21:21:00 +01:00

moritz added this to the Sprint 13: 19.02-26.02 project

2026-03-04 21:21:03 +01:00

moritz force-pushed feat/feetype_filter from d214789872

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/promote/production Build is passing

Details

to 5ab73aada6

continuous-integration/drone/push Build was killed

Details