local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 53 Pull requests 1 Projects 2 Releases 3 Packages 1 Activity Actions

Implements more button consistency #471

Open
carla wants to merge 6 commits from feature/ux_button_concistency into main
pull from: feature/ux_button_concistency
merge into: local-it:main
Conversation 1 Commits 6 Files changed 18 +641 -523
carla commented 2026-03-12 16:17:15 +01:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing

  • New Feature

  • Breaking Change

  • Refactoring

  • The buttons in the new and edit forms should now all be on the bottom of the form on the right (left cancel, right Save....")

  • The active tab is a bit bigger and bolder font

  • the memberfeepayment type settings buttons are rearranged

What has been changed?

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

## Description of the implemented changes The changes were: - [ ] Bugfixing - [ ] New Feature - [ ] Breaking Change - [x] Refactoring - The buttons in the new and edit forms should now all be on the bottom of the form on the right (left cancel, right Save....") - The active tab is a bit bigger and bolder font - the memberfeepayment type settings buttons are rearranged ## What has been changed? <!--- List the things you changed --> ## Definition of Done ### Code Quality - [ ] No new technical depths - [ ] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [ ] Tests for new code are written - [ ] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes <!--- Add any additional information for the reviewers here -->
carla added 4 commits 2026-03-12 16:17:17 +01:00
i18n: update translations
All checks were successful
continuous-integration/drone/push Build is passing
Details
5aa0e4679a
i18n: fix translations after merge
All checks were successful
continuous-integration/drone/push Build is passing
Details
a0a76b6ffc
simon commented 2026-03-13 19:12:50 +01:00
Owner
Copy link

I think we should generally stick closer to daisyUI components.
e.g. there are various implementations for tabs with a clear indicator on which is active (e.g. underscore)

the new and edit member buttons - I think its fine for now, but we need a different approach I think. Would address this in the near future.

the memberfee setting buttons are positioned better now, I think!

I think we should generally stick closer to daisyUI components. e.g. there are various implementations for tabs with a clear indicator on which is active (e.g. underscore) the new and edit member buttons - I think its fine for now, but we need a different approach I think. Would address this in the near future. the memberfee setting buttons are positioned better now, I think!
simon added 1 commit 2026-03-13 19:20:20 +01:00
fix: failing tests from full suite
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/promote/production Build was killed
Details
08c32dce7b
simon added 1 commit 2026-03-13 19:24:04 +01:00
revert 08c32dce7b
Some checks reported errors
continuous-integration/drone/push Build was killed
Details
81fb794c76 
revert fix: failing tests from full suite
Some checks are pending
continuous-integration/drone/push Build was killed
Details
continuous-integration/drone/promote/production
Required
This pull request has changes conflicting with the target branch.
  • lib/mv_web/live/group_live/form.ex
  • lib/mv_web/live/membership_fee_type_live/form.ex
  • lib/mv_web/live/role_live/form.ex
  • lib/mv_web/live/user_live/form.ex
  • priv/gettext/de/LC_MESSAGES/default.po
  • priv/gettext/default.pot
  • priv/gettext/en/LC_MESSAGES/default.po
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/ux_button_concistency:feature/ux_button_concistency
git checkout feature/ux_button_concistency
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
optional

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#471
No description provided.
Delete branch "feature/ux_button_concistency"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?