Fix sort by custom date closes #496

moritz commented

2026-06-15 16:28:09 +02:00

Owner

Description of the implemented changes

The changes were:

Bugfixing
New Feature
Breaking Change
Refactoring

Sorting the member list (and the member export) by a custom field of type date ordered the rows like day-first text instead of chronologically. This fixes the ordering so custom date columns sort by actual calendar order, the same way the built-in join/exit dates already do.

What has been changed?

Add chronological sort key for custom :date fields
Order member list chronologically by custom :date fields
Order member export chronologically by custom :date fields

Definition of Done

Code Quality

No new technical depths
Linting passed
Documentation is added were needed

Accessibility

New elements are properly defined with html-tags
Colour contrast follows WCAG criteria
Aria labels are added when needed
Everything is accessible by keyboard
Tab-Order is comprehensible
All interactive elements have a visible focus

Testing

Tests for new code are written
All tests pass
axe-core dev tools show no critical or major issues

Additional Notes

Follow-up candidate (out of scope here): a pre-existing module Mv.Membership.MemberExportSort (used by the PDF/CSV build path) sorts dates via ISO8601 strings — functionally correct, but it could later be unified with the new shared CustomFieldSort helper for one sort authority across all export paths.

## Description of the implemented changes The changes were: - [x] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring Sorting the member list (and the member export) by a custom field of type date ordered the rows like day-first text instead of chronologically. This fixes the ordering so custom date columns sort by actual calendar order, the same way the built-in join/exit dates already do. ## What has been changed? - Add chronological sort key for custom :date fields - Order member list chronologically by custom :date fields - Order member export chronologically by custom :date fields ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - Follow-up candidate (out of scope here): a pre-existing module `Mv.Membership.MemberExportSort` (used by the PDF/CSV build path) sorts dates via ISO8601 strings — functionally correct, but it could later be unified with the new shared `CustomFieldSort` helper for one sort authority across all export paths.

moritz added 4 commits 2026-06-15 16:28:09 +02:00

fix(membership): add chronological sort key for custom :date fields 1aaa0ece5d

Custom :date values are real Date structs; sorting them by Erlang term
order compares day, then month, then year, so the member list ordered
them like day-first text instead of chronologically. Derive the sort key
from a single shared helper that maps a date to its Gregorian day count,
leaving the other value types at their already-correct natural order.

fix(member): order member list chronologically by custom :date fields 6d4629ef5b

fix(export): order member export chronologically by custom :date fields 2eda661e37

docs(changelog): record custom-date sorting fix under Unreleased

continuous-integration/drone/push Build was killed

Details

continuous-integration/drone/promote/production Build is passing

Details

346291cc0d