Clean up Member leftovers from the Member resource split closes #588 #589

Merged
simon merged 2 commits from issue/mitgliederverwaltung-588 into main 2026-10-14 16:51:37 +02:00
Owner

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Clean up Member leftovers from the Member resource split (#537): remove the unused field-visibility helper Mv.Membership.Member.FieldVisibility, which duplicated the overview's MvWeb.MemberLive.Index.FieldVisibility, and make the cycle-generation log name the user who actually created or edited the member instead of always reporting system.

What has been changed?

  • Remove unused FieldVisibility module
  • Log the acting user as cycle-generation initiator

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

  • The no-actor case (log says system) has no dedicated test: creating a member without an actor already fails in RequiredCustomFields and the fee-type check, so it is unreachable through create_member; the nil → system mapping in CycleSync is unchanged.
## Description of the implemented changes The changes were: - [x] Bugfixing - [ ] New Feature - [ ] Breaking Change - [x] Refactoring Clean up Member leftovers from the Member resource split (#537): remove the unused field-visibility helper `Mv.Membership.Member.FieldVisibility`, which duplicated the overview's `MvWeb.MemberLive.Index.FieldVisibility`, and make the cycle-generation log name the user who actually created or edited the member instead of always reporting `system`. ## What has been changed? - Remove unused FieldVisibility module - Log the acting user as cycle-generation initiator ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - The no-actor case (log says `system`) has no dedicated test: creating a member without an actor already fails in `RequiredCustomFields` and the fee-type check, so it is unreachable through `create_member`; the `nil` → `system` mapping in `CycleSync` is unchanged.
fix(member): log the acting user as cycle-generation initiator
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/promote/production Build is passing
a0ab5df4c2
simon merged commit d9093a1f43 into main 2026-10-14 16:51:37 +02:00
simon deleted branch issue/mitgliederverwaltung-588 2026-10-14 16:51:37 +02:00
Sign in to join this conversation.
No description provided.