Fix remaining flaky tests closes #598

simon commented

2026-10-17 08:44:08 +02:00

Owner

Description of the implemented changes

The changes were:

Bugfixing
New Feature
Breaking Change
Refactoring

Fix remaining flaky tests (unordered search result, async log capture, delete modal): the flaky search test asserted an order on a read action that has no sort and no production caller, and the flaky HasPermission tests asserted an empty log in an async file. The unused action is removed and the search tests now exercise the member overview query users actually see; the vacuous log tests are dropped. The delete-modal flake did not recur in any run and stays documented.

What has been changed?

Drop log-capture tests that could only fail on foreign logs
Drop the unused :search action and test search via the overview query
Warn against empty-log and ordered assertions in async tests

Definition of Done

Code Quality

No new technical depths
Linting passed
Documentation is added were needed

Accessibility

New elements are properly defined with html-tags
Colour contrast follows WCAG criteria
Aria labels are added when needed
Everything is accessible by keyboard
Tab-Order is comprehensible
All interactive elements have a visible focus

Testing

Tests for new code are written
All tests pass
axe-core dev tools show no critical or major issues

Additional Notes

Verified with three full fast-suite runs on the seeds of the earlier flakes (511498, 435950, 237): all green.
The reproduction of the async capture_log leak (a warning from an unrelated process lands in the capture) was run as a throwaway test and is not part of the branch.
F2 touches 9 files (+103/−261, mostly test retargeting and deletions).

## Description of the implemented changes The changes were: - [ ] Bugfixing - [ ] New Feature - [ ] Breaking Change - [x] Refactoring Fix remaining flaky tests (unordered search result, async log capture, delete modal): the flaky search test asserted an order on a read action that has no sort and no production caller, and the flaky HasPermission tests asserted an empty log in an async file. The unused action is removed and the search tests now exercise the member overview query users actually see; the vacuous log tests are dropped. The delete-modal flake did not recur in any run and stays documented. ## What has been changed? - Drop log-capture tests that could only fail on foreign logs - Drop the unused :search action and test search via the overview query - Warn against empty-log and ordered assertions in async tests ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - Verified with three full fast-suite runs on the seeds of the earlier flakes (511498, 435950, 237): all green. - The reproduction of the async `capture_log` leak (a warning from an unrelated process lands in the capture) was run as a throwaway test and is not part of the branch. - F2 touches 9 files (+103/−261, mostly test retargeting and deletions).

simon added 4 commits

2026-10-17 08:44:08 +02:00

test(authorization): drop log-capture tests that could only fail on foreign logs 22685cbc24

The failure message is logged at debug, below the test log level, so the
capture was always empty and the assertion passed only through log == "".
In async runs a warning from a concurrent test could land in the capture and
fail it. The access-denied behaviour stays covered by the return-value tests.

refactor(member): drop the unused :search action and test search via the overview query 40012ed3b7

docs(test): warn against empty-log and ordered assertions in async tests 2053c52ca5

Merge remote-tracking branch 'origin/main' into issue/mitgliederverwaltung-598

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/promote/production Build is passing

Details

954aeb1f2a

simon merged commit edfc8e98fb into main

2026-10-17 08:58:44 +02:00

simon deleted branch issue/mitgliederverwaltung-598

2026-10-17 08:58:45 +02:00