silence ci phx-change warnings closes #600

simon commented

2026-10-17 08:57:47 +02:00

Owner

Description of the implemented changes

The changes were:

Bugfixing
New Feature
Breaking Change
Refactoring

Silence CI warnings: every phx-change form now carries a stable id, so LiveView can recover form state after a reconnect and the 285 "Detected a form with phx-change but missing id" warnings disappear from the CI output. A missing form id now fails the test suite instead of only warning, and the expected "no actor in context" log lines are captured in the test that triggers them.

What has been changed?

Give every phx-change form a stable id so LiveView can recover it
Fail tests on phx-change forms without an id
Capture the expected no-actor warning in the link-state probe

Definition of Done

Code Quality

No new technical depths
Linting passed
Documentation is added were needed

Accessibility

New elements are properly defined with html-tags
Colour contrast follows WCAG criteria
Aria labels are added when needed
Everything is accessible by keyboard
Tab-Order is comprehensible
All interactive elements have a visible focus

Testing

Tests for new code are written
All tests pass
axe-core dev tools show no critical or major issues

Additional Notes

The "found quoted keyword" warnings from the issue are out of scope: they come from Sobelow parsing mix.lock (Mix quotes those keys on purpose), and Sobelow 0.16.0 is the latest release, so rewriting mix.lock would not help. mix.lock is unchanged; this needs a separate upstream fix in Sobelow.

## Description of the implemented changes The changes were: - [x] Bugfixing - [ ] New Feature - [ ] Breaking Change - [ ] Refactoring Silence CI warnings: every `phx-change` form now carries a stable id, so LiveView can recover form state after a reconnect and the 285 "Detected a form with phx-change but missing id" warnings disappear from the CI output. A missing form id now fails the test suite instead of only warning, and the expected "no actor in context" log lines are captured in the test that triggers them. ## What has been changed? - Give every phx-change form a stable id so LiveView can recover it - Fail tests on phx-change forms without an id - Capture the expected no-actor warning in the link-state probe ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [ ] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes The "found quoted keyword" warnings from the issue are out of scope: they come from Sobelow parsing `mix.lock` (Mix quotes those keys on purpose), and Sobelow 0.16.0 is the latest release, so rewriting `mix.lock` would not help. `mix.lock` is unchanged; this needs a separate upstream fix in Sobelow.

simon added 4 commits

2026-10-17 08:57:47 +02:00

fix(web): give every phx-change form a stable id so LiveView can recover it 5a3caa9f49

test: fail tests on phx-change forms without an id 47fca8ad45

test(member): capture the expected no-actor warning in the link-state probe 216b7e3ec3

Merge remote-tracking branch 'origin/main' into issue/mitgliederverwaltung-600

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/promote/production Build is passing

Details

21816ce66c

simon merged commit aff2626e66 into main