Remove uncalled code and unreachable validations, and bring the Ash resource snapshots up to date closes #631 #633
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!633
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-631"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #631
Description of the implemented changes
The changes were:
Code hygiene: uncalled code and unreachable validations are gone, the system actor cache has tests, and resources, snapshots and migrations agree again, with CI now keeping them in line.
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
ash_requiredSQL function that ash_postgres generates calls to. It changes no tables or data; rollback removes the function. Tested as an upgrade frommainon a seeded database: row counts unchanged, schema diff only that function.mix ash.codegenonmainwould add the existingjoin_requests.reviewed_by_displaycolumn and offer to drop the long-renamedpropertiestables. The column is therefore a snapshot-only change, and the stale snapshot directories are deleted.just lintand Drone now runmix ash.codegen --check. A resource change without its migration and snapshot turns CI red, and so does a dependency update that raises the Ash functions version, including Renovate PRs, until the migration is generated.update_member_field_visibility/2,update_single_member_field_visibility/2andMv.Membership.Setting.Changes.UpdateSingleMemberFieldVisibilityare removed; the form usesupdate_single_member_field/2.