Edit small entities on their own pages, switch flags in tables and undo removed relations closes #629 #634

Merged
simon merged 17 commits from issue/mitgliederverwaltung-629 into main 2026-11-02 18:00:17 +01:00
Owner

closes #629
closes #449

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Small entity editing: data fields and roles are edited on their own pages, flags are switched directly in the tables, removed relations can be undone from a toast, and a member's fee cycles are named by short labels with their status set in one click.

What has been changed?

  • Edit a data field on its own page with a URL instead of in place
  • Switch a data field's Required and Show in overview directly in the table
  • Change member fields only by their switches, with the email's lock explained below the table
  • Open a role's edit page from the list and redirect its former detail URL there
  • Make the entity name in list rows a real link to the row's page, looking like plain text
  • Close toasts only through their Close button, announce them by kind and let info leave after 5 s like success
  • Offer Undo after removing a member from a group and keep keyboard focus on the list
  • Offer Undo after removing a field from the join form, restoring its place and required flag
  • Let the email field move like the other fields and explain its locked Required in a note below the table
  • Show the row link with switches and Remove, every toast kind, the undo toast and the spinner
  • Confirm added members with a toast that names one member or counts several
  • Let Tab pass a fee badge and open its open-cycles list with Arrow Down instead of on focus
  • Name cycles by short label, set their status with one click and delete all of them from the section menu in one transaction
  • Decide between page, dialog and inline editing by six criteria and drop the interim rules for small entities
  • Right-align fee type amounts with tabular figures in the text font
  • Record small entity editing, undo after removing and the fee cycles section under Unreleased

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

Part of #188 (U9).

#261 can be closed after this merge: deleting a data field happens in the danger zone of its own edit page, and the entity name in every list is the link to its page, so editing no longer depends on an action column.

Larger commits: the data field edit page, the data field switches, the member field switches, the role edit page, the entity name link in list rows (26 files), the toast behavior, Undo for group members, Undo for join form fields, the movable email field and the fee cycles section touch more than 5 files or 150 lines each.

Toasts no longer close on a click anywhere on them, only through their Close button. Info and success toasts are role="status", warning and error toasts role="alert". Info and success toasts leave after 5 s; warnings, errors and toasts with Undo stay until closed.

The email field of the join form is no longer pinned to the first place.

"Delete all cycles …" moved from the member's danger zone to the menu in the header of the fee cycles section and deletes in one transaction. DESIGN_GUIDELINES §8.7 documents this as the exception for sub-records that only appear inside their parent; §14 scopes "delete only via the danger zone" to entities.

The fee types table shows amounts right-aligned with tabular figures in the text font instead of a monospace font.

Removed: the in-place CustomFieldLive.FormComponent and MemberFieldLive.FormComponent, the role detail page RoleLive.Show (its URL redirects to the edit page) and the JoinFormFieldOrder helper.

closes #629 closes #449 ## Description of the implemented changes The changes were: - [x] Bugfixing - [x] New Feature - [ ] Breaking Change - [x] Refactoring Small entity editing: data fields and roles are edited on their own pages, flags are switched directly in the tables, removed relations can be undone from a toast, and a member's fee cycles are named by short labels with their status set in one click. ## What has been changed? - Edit a data field on its own page with a URL instead of in place - Switch a data field's Required and Show in overview directly in the table - Change member fields only by their switches, with the email's lock explained below the table - Open a role's edit page from the list and redirect its former detail URL there - Make the entity name in list rows a real link to the row's page, looking like plain text - Close toasts only through their Close button, announce them by kind and let info leave after 5 s like success - Offer Undo after removing a member from a group and keep keyboard focus on the list - Offer Undo after removing a field from the join form, restoring its place and required flag - Let the email field move like the other fields and explain its locked Required in a note below the table - Show the row link with switches and Remove, every toast kind, the undo toast and the spinner - Confirm added members with a toast that names one member or counts several - Let Tab pass a fee badge and open its open-cycles list with Arrow Down instead of on focus - Name cycles by short label, set their status with one click and delete all of them from the section menu in one transaction - Decide between page, dialog and inline editing by six criteria and drop the interim rules for small entities - Right-align fee type amounts with tabular figures in the text font - Record small entity editing, undo after removing and the fee cycles section under Unreleased ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes Part of #188 (U9). #261 can be closed after this merge: deleting a data field happens in the danger zone of its own edit page, and the entity name in every list is the link to its page, so editing no longer depends on an action column. Larger commits: the data field edit page, the data field switches, the member field switches, the role edit page, the entity name link in list rows (26 files), the toast behavior, Undo for group members, Undo for join form fields, the movable email field and the fee cycles section touch more than 5 files or 150 lines each. Toasts no longer close on a click anywhere on them, only through their Close button. Info and success toasts are `role="status"`, warning and error toasts `role="alert"`. Info and success toasts leave after 5 s; warnings, errors and toasts with Undo stay until closed. The email field of the join form is no longer pinned to the first place. "Delete all cycles …" moved from the member's danger zone to the menu in the header of the fee cycles section and deletes in one transaction. DESIGN_GUIDELINES §8.7 documents this as the exception for sub-records that only appear inside their parent; §14 scopes "delete only via the danger zone" to entities. The fee types table shows amounts right-aligned with tabular figures in the text font instead of a monospace font. Removed: the in-place `CustomFieldLive.FormComponent` and `MemberFieldLive.FormComponent`, the role detail page `RoleLive.Show` (its URL redirects to the edit page) and the `JoinFormFieldOrder` helper.
# Conflicts:
#	test/mv_web/live/member_field_live/index_component_test.exs
docs(changelog): record small entity editing, undo after removing and the fee cycles section under Unreleased
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/promote/production Build is passing
82efab58a6
simon merged commit 0cad7a7276 into main 2026-11-02 18:00:17 +01:00
simon deleted branch issue/mitgliederverwaltung-629 2026-11-02 18:00:17 +01:00
Sign in to join this conversation.
No description provided.