Search and sort every list, frame lists with one empty state and show top-level titles in the top bar closes #632 #642
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!642
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-632"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #632, closes #174
Description of the implemented changes
The changes were:
Lists and tables: users, groups and join requests can be searched and sorted with the state in the URL like the members overview, every list stands in one frame with one empty state, tables show numbers and yes/no one way and fill their sections, and pages reached from the sidebar show their title in the top bar.
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
Part of #188 (U10).
#174 is solved by the shared sort header: its
<th>carriesaria-sortand its button has the shared focus ring on every sortable table.Prepared for #15:
Mv.Membership.DataFieldOrderis the one place that orders data fields. The custom field read action sorts withcustom_field_sort/0, and the overview columns and the data field settings take the member fields frommember_fields/0, so the overview, the member form, the member page and the data field settings list them in one order (test/mv_web/live/data_field_order_test.exs). Checked against #15: the same order in overview and edit form holds, and member fields and custom fields each have their own switch point, so a stored order replaces these two functions without another refactor.Larger commits: the sort header (26 files), users search, join requests list, member list frame, groups search and the fee settings section touch more than 5 files or 150 lines each.
Behavior a reviewer might not expect:
lg; the page has no title row of its own.Documented guideline exceptions: the two statistics tables and the import preview stay raw
<table>s (§8.8);<.sortable_table>still has no move buttons and Escape only releases the grabbed row (§8.11).Removed:
SortHeaderComponent,Table.sort_button/1and the overview'supdate_sort_components/Sort.header_idglue.