Search and sort every list, frame lists with one empty state and show top-level titles in the top bar closes #632 #642

Merged
simon merged 24 commits from issue/mitgliederverwaltung-632 into main 2026-11-04 11:40:38 +01:00
Owner

closes #632, closes #174

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Lists and tables: users, groups and join requests can be searched and sorted with the state in the URL like the members overview, every list stands in one frame with one empty state, tables show numbers and yes/no one way and fill their sections, and pages reached from the sidebar show their title in the top bar.

What has been changed?

  • Render every sort header with one function component
  • Frame list pages like sections and give empty lists one look
  • Search users and keep their sort in the URL
  • Search and sort groups, and frame the list with its empty state
  • Show one list with a status filter, search and sort instead of two tables
  • Frame the member list with its two toolbar rows and show an empty list without a table header
  • Show a top-level page's title in the top bar instead of a row of its own
  • Tighten the list's toolbar rows in the compact view
  • Let a section's table fill it, add a note row below and allow nested sections
  • Fill the data field sections with their tables and show the email lock as a note row
  • Show the join form's fields as a nested section with their own header and lock note
  • Show a section's key values under its title
  • Name the fee type under the section title and let the cycles table and receipts use the shared table
  • Let the fee types table fill its section and keep their rules open in a section of their own
  • Let a group's member table fill its section and count the members under the title
  • Frame the role list like the other lists and leave a missing description empty
  • Show yes and no in tables as a check mark or an empty cell, read as Yes or No
  • Take the order of data fields from one module wherever they are listed
  • Show the list frame, empty states, yes and no cells and the section variants
  • Describe the list frame, sort header, empty states, yes and no cells and section variants as built
  • Bring the project tree and the view example up to date with the list and page rules
  • Drop the purpose sentences under top-level page titles
  • Record searchable lists, list frames, empty states and the title in the top bar under Unreleased

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

Part of #188 (U10).

#174 is solved by the shared sort header: its <th> carries aria-sort and its button has the shared focus ring on every sortable table.

Prepared for #15: Mv.Membership.DataFieldOrder is the one place that orders data fields. The custom field read action sorts with custom_field_sort/0, and the overview columns and the data field settings take the member fields from member_fields/0, so the overview, the member form, the member page and the data field settings list them in one order (test/mv_web/live/data_field_order_test.exs). Checked against #15: the same order in overview and edit form holds, and member fields and custom fields each have their own switch point, so a stored order replaces these two functions without another refactor.

Larger commits: the sort header (26 files), users search, join requests list, member list frame, groups search and the fee settings section touch more than 5 files or 150 lines each.

Behavior a reviewer might not expect:

  • Pages whose breadcrumb trail is only the page itself (members, groups, statistics, join requests, settings, data fields, fee settings, import, users, roles) show their H1 in the top bar from lg; the page has no title row of its own.
  • The purpose sentence under the title of six settings and administration pages is gone; only edit pages keep a subtitle, the record's name (DESIGN_GUIDELINES §2.4).
  • Join requests open on "Open", newest first; decided requests are one filter click away. Requests awaiting the applicant's email confirmation stay hidden as before.
  • A list without any data shows its empty state without the search row.
  • Search, sort and the join request status live in the URL; unknown or malformed values fall back to the default without creating atoms.

Documented guideline exceptions: the two statistics tables and the import preview stay raw <table>s (§8.8); <.sortable_table> still has no move buttons and Escape only releases the grabbed row (§8.11).

Removed: SortHeaderComponent, Table.sort_button/1 and the overview's update_sort_components / Sort.header_id glue.

closes #632, closes #174 ## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [x] Refactoring Lists and tables: users, groups and join requests can be searched and sorted with the state in the URL like the members overview, every list stands in one frame with one empty state, tables show numbers and yes/no one way and fill their sections, and pages reached from the sidebar show their title in the top bar. ## What has been changed? - Render every sort header with one function component - Frame list pages like sections and give empty lists one look - Search users and keep their sort in the URL - Search and sort groups, and frame the list with its empty state - Show one list with a status filter, search and sort instead of two tables - Frame the member list with its two toolbar rows and show an empty list without a table header - Show a top-level page's title in the top bar instead of a row of its own - Tighten the list's toolbar rows in the compact view - Let a section's table fill it, add a note row below and allow nested sections - Fill the data field sections with their tables and show the email lock as a note row - Show the join form's fields as a nested section with their own header and lock note - Show a section's key values under its title - Name the fee type under the section title and let the cycles table and receipts use the shared table - Let the fee types table fill its section and keep their rules open in a section of their own - Let a group's member table fill its section and count the members under the title - Frame the role list like the other lists and leave a missing description empty - Show yes and no in tables as a check mark or an empty cell, read as Yes or No - Take the order of data fields from one module wherever they are listed - Show the list frame, empty states, yes and no cells and the section variants - Describe the list frame, sort header, empty states, yes and no cells and section variants as built - Bring the project tree and the view example up to date with the list and page rules - Drop the purpose sentences under top-level page titles - Record searchable lists, list frames, empty states and the title in the top bar under Unreleased ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes Part of #188 (U10). #174 is solved by the shared sort header: its `<th>` carries `aria-sort` and its button has the shared focus ring on every sortable table. Prepared for #15: `Mv.Membership.DataFieldOrder` is the one place that orders data fields. The custom field read action sorts with `custom_field_sort/0`, and the overview columns and the data field settings take the member fields from `member_fields/0`, so the overview, the member form, the member page and the data field settings list them in one order (`test/mv_web/live/data_field_order_test.exs`). Checked against #15: the same order in overview and edit form holds, and member fields and custom fields each have their own switch point, so a stored order replaces these two functions without another refactor. Larger commits: the sort header (26 files), users search, join requests list, member list frame, groups search and the fee settings section touch more than 5 files or 150 lines each. Behavior a reviewer might not expect: - Pages whose breadcrumb trail is only the page itself (members, groups, statistics, join requests, settings, data fields, fee settings, import, users, roles) show their H1 in the top bar from `lg`; the page has no title row of its own. - The purpose sentence under the title of six settings and administration pages is gone; only edit pages keep a subtitle, the record's name (DESIGN_GUIDELINES §2.4). - Join requests open on "Open", newest first; decided requests are one filter click away. Requests awaiting the applicant's email confirmation stay hidden as before. - A list without any data shows its empty state without the search row. - Search, sort and the join request status live in the URL; unknown or malformed values fall back to the default without creating atoms. Documented guideline exceptions: the two statistics tables and the import preview stay raw `<table>`s (§8.8); `<.sortable_table>` still has no move buttons and Escape only releases the grabbed row (§8.11). Removed: `SortHeaderComponent`, `Table.sort_button/1` and the overview's `update_sort_components` / `Sort.header_id` glue.
Merge remote-tracking branch 'origin/main' into issue/mitgliederverwaltung-632
Some checks reported errors
continuous-integration/drone/push Build is passing
continuous-integration/drone/promote/production Build was killed
0c15e74500
simon merged commit 39459db835 into main 2026-11-04 11:40:38 +01:00
simon deleted branch issue/mitgliederverwaltung-632 2026-11-04 11:40:38 +01:00
Sign in to join this conversation.
No description provided.