Keep roles other than Admin on single sign-on closes #646 #649
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!649
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-646"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #646
Description of the implemented changes
The changes were:
Single sign-on: a role assigned in Mila, such as a board role, survives every sign-in; the admin group grants and removes only the Admin role.
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
Mv.OidcRoleSync.decide/2): in the admin group → Admin; an Admin not in it → Mitglied, also when the claim is an empty list; any other role stays. A claim missing from both the ID token user info and the access token, or one that is not a list of strings, changes nothing and logs a warning.EnsureAdminRemainsinside the sign-in transaction and rolled the whole sign-in back, so that admin could not sign in at all. The role update now runs withrollback_on_error?: false; the refusal is logged and the sign-in succeeds.77b8564d(sync rewrite plus its tests, incl. a serialoidc_role_sync_logging_test.exsthat captures logs).EnvConfig.env_group/env_inputgain an optionalhelpattribute for it.