Approve join requests with data fields and check the join form closes #645 #653
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!653
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-645"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #645
Description of the implemented changes
The changes were:
Join requests: a request whose join form contains data fields can be approved, the reviewer sees what blocks an approval before clicking and fills in missing required values in a dialog, and the public join form checks every value on the server.
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
3205cf94(approve with typed values, newMemberAttrs),0db4648d,9470eb05(server-side checks on/join),d9a6c133(pre-check, blocked button, fill-in dialog),740e51b2and7e6cc6e5(join form requirements decided by the club, hint on the data field pages).0db4648dlocked the join form's "Required" switch for fields every member must have;7e6cc6e5undoes that lock after acceptance: the club decides what the join form requires, and a reviewer fills in missing values when approving. Only the e-mail stays locked.soft_disabledattribute on<.button>(aria-disabled, stays focusable, raises on link buttons); documented in DESIGN_GUIDELINES.md §5.CustomFieldCoercermoved from the CSV import toMv.Membership, shared by import and join flow.FOR UPDATE); the SQL sandbox cannot run two transactions at once, so the lock itself has no test — the outcome (one member per request) is covered by the domain and two-tab LiveView tests.