Approve join requests with data fields and check the join form closes #645 #653

Merged
simon merged 15 commits from issue/mitgliederverwaltung-645 into main 2026-11-09 22:54:42 +01:00
Owner

closes #645

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Join requests: a request whose join form contains data fields can be approved, the reviewer sees what blocks an approval before clicking and fills in missing required values in a dialog, and the public join form checks every value on the server.

What has been changed?

  • Share the custom field coercer between the import and the join flow
  • Approve requests with required custom fields, converting each submitted value to its field's type
  • Tell what blocks an approval, also before the reviewer approves
  • Require the fields every member must have and offer to add the missing ones
  • Check every submitted value on the server and show each error at its field
  • Keep the public join page within the screen on phones
  • Show what blocks an approval before the click and ask for missing required values when approving
  • Give a new installation a join form with name and address fields
  • Run every field type and required combination from the join form to the member
  • Keep the missing required field warning short and say the button adds them as required
  • Describe the join request email check and the public header as they work now
  • Show a request decided meanwhile as decided, link the member that has its email and let a missing name be filled in
  • Let the club choose which fields the join form requires and point out the ones a reviewer fills in
  • Record approving join requests with data fields, filling in missing required values and the checked join form under Unreleased

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

  • Larger commits: 3205cf94 (approve with typed values, new MemberAttrs), 0db4648d, 9470eb05 (server-side checks on /join), d9a6c133 (pre-check, blocked button, fill-in dialog), 740e51b2 and 7e6cc6e5 (join form requirements decided by the club, hint on the data field pages).
  • 0db4648d locked the join form's "Required" switch for fields every member must have; 7e6cc6e5 undoes that lock after acceptance: the club decides what the join form requires, and a reviewer fills in missing values when approving. Only the e-mail stays locked.
  • Behavior changes a reviewer may not expect: an unchecked optional checkbox becomes "No" on the member; a request whose e-mail already belongs to a member cannot be approved (the page links that member); new installations get e-mail, first/last name and address on the join form (existing installations are untouched, bootstrap seeds do not run there).
  • New soft_disabled attribute on <.button> (aria-disabled, stays focusable, raises on link buttons); documented in DESIGN_GUIDELINES.md §5.
  • CustomFieldCoercer moved from the CSV import to Mv.Membership, shared by import and join flow.
  • The approval locks the request row (FOR UPDATE); the SQL sandbox cannot run two transactions at once, so the lock itself has no test — the outcome (one member per request) is covered by the domain and two-tab LiveView tests.
closes #645 ## Description of the implemented changes The changes were: - [x] Bugfixing - [x] New Feature - [ ] Breaking Change - [x] Refactoring Join requests: a request whose join form contains data fields can be approved, the reviewer sees what blocks an approval before clicking and fills in missing required values in a dialog, and the public join form checks every value on the server. ## What has been changed? - Share the custom field coercer between the import and the join flow - Approve requests with required custom fields, converting each submitted value to its field's type - Tell what blocks an approval, also before the reviewer approves - Require the fields every member must have and offer to add the missing ones - Check every submitted value on the server and show each error at its field - Keep the public join page within the screen on phones - Show what blocks an approval before the click and ask for missing required values when approving - Give a new installation a join form with name and address fields - Run every field type and required combination from the join form to the member - Keep the missing required field warning short and say the button adds them as required - Describe the join request email check and the public header as they work now - Show a request decided meanwhile as decided, link the member that has its email and let a missing name be filled in - Let the club choose which fields the join form requires and point out the ones a reviewer fills in - Record approving join requests with data fields, filling in missing required values and the checked join form under Unreleased ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - Larger commits: 3205cf94 (approve with typed values, new `MemberAttrs`), 0db4648d, 9470eb05 (server-side checks on `/join`), d9a6c133 (pre-check, blocked button, fill-in dialog), 740e51b2 and 7e6cc6e5 (join form requirements decided by the club, hint on the data field pages). - 0db4648d locked the join form's "Required" switch for fields every member must have; 7e6cc6e5 undoes that lock after acceptance: the club decides what the join form requires, and a reviewer fills in missing values when approving. Only the e-mail stays locked. - Behavior changes a reviewer may not expect: an unchecked optional checkbox becomes "No" on the member; a request whose e-mail already belongs to a member cannot be approved (the page links that member); new installations get e-mail, first/last name and address on the join form (existing installations are untouched, bootstrap seeds do not run there). - New `soft_disabled` attribute on `<.button>` (`aria-disabled`, stays focusable, raises on link buttons); documented in DESIGN_GUIDELINES.md §5. - `CustomFieldCoercer` moved from the CSV import to `Mv.Membership`, shared by import and join flow. - The approval locks the request row (`FOR UPDATE`); the SQL sandbox cannot run two transactions at once, so the lock itself has no test — the outcome (one member per request) is covered by the domain and two-tab LiveView tests.
# Conflicts:
#	priv/gettext/de/LC_MESSAGES/default.po
#	priv/gettext/default.pot
#	priv/gettext/en/LC_MESSAGES/default.po
docs(changelog): record approving join requests with data fields, filling in missing required values and the checked join form under Unreleased
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/promote/production Build is passing
26b7012812
simon merged commit a1b43909e1 into main 2026-11-09 22:54:42 +01:00
simon deleted branch issue/mitgliederverwaltung-645 2026-11-09 22:54:42 +01:00
Sign in to join this conversation.
No description provided.