Split the grown component modules by family closes #652 #659
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!659
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-652"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #652
Description of the implemented changes
The changes were:
Component modules: the entity picker and the dialogs each get a module of their own, and the filter chip row order becomes a pure, unit-tested module, so
form.exandoverlay.exeach hold one component family again; nothing changes for users.What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
@surfaceinimport_surface_test.exsis unchanged, both new modules are imported throughMvWeb.html_helpers/0.MvWeb.Components.Combobox.ComboboxandMvWeb.Components.Dialog.Modal; a test pins the exact names.role_deletion.exanduser_deletion.eximportconfirm_dialog/1fromDialognow, besides the member and group deletion modules the issue names.add_filter_builder_component.exends at 631 lines instead of the 600 the issue aims for; getting below would mean moving more than the chip row order.form.exis 700 lines,overlay.ex607.