Split the grown component modules by family closes #652 #659

Merged
simon merged 3 commits from issue/mitgliederverwaltung-652 into main 2026-11-12 08:10:41 +01:00
Owner

closes #652

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Component modules: the entity picker and the dialogs each get a module of their own, and the filter chip row order becomes a pure, unit-tested module, so form.ex and overlay.ex each hold one component family again; nothing changes for users.

What has been changed?

  • Move the entity picker into its own component module
  • Move the dialogs into their own component module
  • Pull the filter chip row order out of the filter builder

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

  • Follows the UI unification; @surface in import_surface_test.exs is unchanged, both new modules are imported through MvWeb.html_helpers/0.
  • The first two commits are large (15 and 22 files, ~600 lines each) but move code verbatim; only doctest module names, imports, moduledocs and test file names change.
  • The colocated hooks are named after their module, so they become MvWeb.Components.Combobox.Combobox and MvWeb.Components.Dialog.Modal; a test pins the exact names.
  • role_deletion.ex and user_deletion.ex import confirm_dialog/1 from Dialog now, besides the member and group deletion modules the issue names.
  • add_filter_builder_component.ex ends at 631 lines instead of the 600 the issue aims for; getting below would mean moving more than the chip row order. form.ex is 700 lines, overlay.ex 607.
  • The component showcase gets its own Combobox and Dialog sections.
closes #652 ## Description of the implemented changes The changes were: - [ ] Bugfixing - [ ] New Feature - [ ] Breaking Change - [x] Refactoring Component modules: the entity picker and the dialogs each get a module of their own, and the filter chip row order becomes a pure, unit-tested module, so `form.ex` and `overlay.ex` each hold one component family again; nothing changes for users. ## What has been changed? - Move the entity picker into its own component module - Move the dialogs into their own component module - Pull the filter chip row order out of the filter builder ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - Follows the UI unification; `@surface` in `import_surface_test.exs` is unchanged, both new modules are imported through `MvWeb.html_helpers/0`. - The first two commits are large (15 and 22 files, ~600 lines each) but move code verbatim; only doctest module names, imports, moduledocs and test file names change. - The colocated hooks are named after their module, so they become `MvWeb.Components.Combobox.Combobox` and `MvWeb.Components.Dialog.Modal`; a test pins the exact names. - `role_deletion.ex` and `user_deletion.ex` import `confirm_dialog/1` from `Dialog` now, besides the member and group deletion modules the issue names. - `add_filter_builder_component.ex` ends at 631 lines instead of the 600 the issue aims for; getting below would mean moving more than the chip row order. `form.ex` is 700 lines, `overlay.ex` 607. - The component showcase gets its own Combobox and Dialog sections.
simon merged commit 9e4a8d5fad into main 2026-11-12 08:10:41 +01:00
simon deleted branch issue/mitgliederverwaltung-652 2026-11-12 08:10:41 +01:00
Sign in to join this conversation.
No description provided.