Check each tree once and gate merges on the pull request check closes #663 #676

Merged
simon merged 8 commits from issue/mitgliederverwaltung-663 into main 2026-11-13 14:18:14 +01:00
Owner

closes #663

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

CI: a pull request runs the full check by itself and that check gates the merge; main publishes an image only after it booted, and releases compile nothing.

What has been changed?

  • Share the CI release steps with a script that needs no dependencies
  • Fail on empty plural translations and on a JavaScript bundle that does not build
  • Skip a check only when another build checks or checked the same tree
  • Publish main's image only after it booted against an empty database
  • Fail a full run when a serial test module grows past its time limit
  • Check each tree once, gate merges on the pull request check and test on the Postgres of production
  • Describe what CI runs on each event and which check protects main
  • Note boot-tested images and the pull request check

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

  • Breaking for the workflow: the promote to production and the pipelines check-fast and check-full-promote are gone. Before merging this, set "Disable Forks" in the Drone repository settings, and once this pull request's check is green, replace the required status check-full with continuous-integration/drone/pr in the branch protection of main (docs/ci.md, Branch protection).
  • Larger commits: the skip script (347 lines, mostly tests), the pipeline rewrite (.drone.jsonnet, 412/116 lines), the serial-time guard (9 files, five of them only a Budget N s. in a serial comment), the boot test (6 files), and the release script (8 files).
  • Behaviour a reviewer might not expect: a push to a branch with an open pull request ends in its first step as successful (the pull request build checks the same commit); main skips its check when its tree already passed the pull request check; pull request builds never write the shared build cache.
  • The boot test sets ADMIN_EMAIL and ADMIN_PASSWORD: a new installation without an admin password does not start (a bug since 1.4.0, reported separately).
  • test/ci/drone_render_test.exs needs jsonnet and is skipped in the CI image.
  • Timings before this change (median over 200 builds, 12.10.–13.11.2026): push → green check-fast 6:20, full check 6:29 (promote extra), merge → published main image ≈ 16 min, tag → draft release 5:14.
closes #663 ## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [x] Breaking Change - [x] Refactoring CI: a pull request runs the full check by itself and that check gates the merge; main publishes an image only after it booted, and releases compile nothing. ## What has been changed? - Share the CI release steps with a script that needs no dependencies - Fail on empty plural translations and on a JavaScript bundle that does not build - Skip a check only when another build checks or checked the same tree - Publish main's image only after it booted against an empty database - Fail a full run when a serial test module grows past its time limit - Check each tree once, gate merges on the pull request check and test on the Postgres of production - Describe what CI runs on each event and which check protects main - Note boot-tested images and the pull request check ## Definition of Done ### Code Quality - [ ] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [ ] New elements are properly defined with html-tags - [ ] Colour contrast follows WCAG criteria - [ ] Aria labels are added when needed - [ ] Everything is accessible by keyboard - [ ] Tab-Order is comprehensible - [ ] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - **Breaking for the workflow:** the promote to `production` and the pipelines `check-fast` and `check-full-promote` are gone. Before merging this, set "Disable Forks" in the Drone repository settings, and once this pull request's check is green, replace the required status `check-full` with `continuous-integration/drone/pr` in the branch protection of `main` (docs/ci.md, Branch protection). - Larger commits: the skip script (347 lines, mostly tests), the pipeline rewrite (`.drone.jsonnet`, 412/116 lines), the serial-time guard (9 files, five of them only a `Budget N s.` in a serial comment), the boot test (6 files), and the release script (8 files). - Behaviour a reviewer might not expect: a push to a branch with an open pull request ends in its first step as successful (the pull request build checks the same commit); `main` skips its check when its tree already passed the pull request check; pull request builds never write the shared build cache. - The boot test sets `ADMIN_EMAIL` and `ADMIN_PASSWORD`: a new installation without an admin password does not start (a bug since 1.4.0, reported separately). - `test/ci/drone_render_test.exs` needs `jsonnet` and is skipped in the CI image. - Timings before this change (median over 200 builds, 12.10.–13.11.2026): push → green check-fast 6:20, full check 6:29 (promote extra), merge → published `main` image ≈ 16 min, tag → draft release 5:14.
simon force-pushed issue/mitgliederverwaltung-663 from 98cd71f3e9
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
to db8f6178d7
Some checks reported errors
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build was killed
2026-11-13 14:07:39 +01:00
Compare
simon force-pushed issue/mitgliederverwaltung-663 from db8f6178d7
Some checks reported errors
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build was killed
to 318a0320da
All checks were successful
continuous-integration/drone/push Build is passing
continuous-integration/drone/pr Build is passing
2026-11-13 14:09:54 +01:00
Compare
simon merged commit 69a2373b3a into main 2026-11-13 14:18:14 +01:00
simon deleted branch issue/mitgliederverwaltung-663 2026-11-13 14:18:14 +01:00
Sign in to join this conversation.
No description provided.