Stop a branch check when its pull request opens while it runs closes #679 #684
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!684
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-679"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #679
Description of the implemented changes
The changes were:
CI: a branch check ends once a pull request is opened for its branch, so the pull request check no longer shares the runner with a second full check of the same commit.
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
check-branchnow asks three times whether its branch has an open pull request: at the start (as before), in a new stepskip-lateafterdeps(before lint and the tests), and every 30 s while the tests run (elixir ci/skip-check.exs watch-pr … -- mix test).check-prandcheck-mainrender exactly as before.mix test(TERM, KILL after 10 s) and ends at the latest after 20 s even if a process outside the group keeps the output open.ci/skip-check.exsalso treats malformed API entries (no map, no integer number) as doubt and lets the check run; before,open-prcrashed on them.deps(~48 s after the start) would have caught 12 of those 55; asking during the tests catches 49.test/ci/drone_render_test.exsneedsjsonnetand is skipped in the CI image.