Send members to their own record after sign-in closes #665 #685

Merged
simon merged 8 commits from issue/mitgliederverwaltung-665 into main 2026-11-13 18:48:05 +01:00
Owner

closes #665

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Members (own_data) landed on the overview after signing in, were refused it and ended up on their account page with an error. They now start on their own member record, and their pages show the areas of that record (my data, my fees, sign-in & security) in a frame without links to pages they cannot open. Board, treasurer and admin start on the overview as before.

What has been changed?

  • Send members to their own record after sign-in and on denied pages
  • Show members their areas in the sidebar and rename the profile entry
  • Show the title in the top bar when no breadcrumb ancestor is visible
  • Show members their own record in the self-service frame
  • Frame account and edit pages for members and name sign-in methods plainly
  • Describe the self-service frame and the home page after sign-in
  • Show members how to leave only on the edit page

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

  • CheckPagePermission.home_path/1 is the one place that decides where a user starts: "/" for actors who may open it, otherwise the own member record when it is linked and may be opened, otherwise the own account page. Sign-in, the plug and the LiveView hook use it; a request for "/" by a member leads home without the access-denied message. Staff keep their account page as the target of a denied page.
  • MvWeb.SelfService decides whether a page gets the self-service frame (the actor may not open /members) and which areas the actor has (each filtered through the page permission). Pages ask it instead of checking roles (DESIGN_GUIDELINES §15.4).
  • The hint telling members to contact the board for an exit is now only on the edit page, not on the detail page.
  • On the member page, members see groups as names (group pages are not theirs) and the edit button only on "My data". Board and admin views are unchanged; a test pins tabs, Back, breadcrumb and group links for the board.
  • Visible for every role: the user menu entry "Profile" is now "Sign-in & security", the account page section is "Sign-in" and the OIDC row "Single Sign-On (SSO)". On staff roles' own account page (no access to the users list) the title moves into the top bar and the Back button to the forbidden users list is gone.
  • The page-permission check on live navigation now refuses a patch to another member's record before that record is loaded (test sends the forged patch).

Release: 1.6.0 (wave 1).

Proposed news entry (for the release file once #683 is merged):

  • Title: Members start on their own data
  • Sentence: After signing in, members see their own member data with their fees and sign-in settings in the menu, instead of an error message.
  • Area: Members / self-service
  • Action needed: no
  • Link: #665
closes #665 ## Description of the implemented changes The changes were: - [x] Bugfixing - [x] New Feature - [ ] Breaking Change - [ ] Refactoring Members (own_data) landed on the overview after signing in, were refused it and ended up on their account page with an error. They now start on their own member record, and their pages show the areas of that record (my data, my fees, sign-in & security) in a frame without links to pages they cannot open. Board, treasurer and admin start on the overview as before. ## What has been changed? - Send members to their own record after sign-in and on denied pages - Show members their areas in the sidebar and rename the profile entry - Show the title in the top bar when no breadcrumb ancestor is visible - Show members their own record in the self-service frame - Frame account and edit pages for members and name sign-in methods plainly - Describe the self-service frame and the home page after sign-in - Show members how to leave only on the edit page ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [x] New elements are properly defined with html-tags - [x] Colour contrast follows WCAG criteria - [x] Aria labels are added when needed - [x] Everything is accessible by keyboard - [x] Tab-Order is comprehensible - [x] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [ ] axe-core dev tools show no critical or major issues ## Additional Notes - `CheckPagePermission.home_path/1` is the one place that decides where a user starts: "/" for actors who may open it, otherwise the own member record when it is linked and may be opened, otherwise the own account page. Sign-in, the plug and the LiveView hook use it; a request for "/" by a member leads home without the access-denied message. Staff keep their account page as the target of a denied page. - `MvWeb.SelfService` decides whether a page gets the self-service frame (the actor may not open `/members`) and which areas the actor has (each filtered through the page permission). Pages ask it instead of checking roles (DESIGN_GUIDELINES §15.4). - The hint telling members to contact the board for an exit is now only on the edit page, not on the detail page. - On the member page, members see groups as names (group pages are not theirs) and the edit button only on "My data". Board and admin views are unchanged; a test pins tabs, Back, breadcrumb and group links for the board. - Visible for every role: the user menu entry "Profile" is now "Sign-in & security", the account page section is "Sign-in" and the OIDC row "Single Sign-On (SSO)". On staff roles' own account page (no access to the users list) the title moves into the top bar and the Back button to the forbidden users list is gone. - The page-permission check on live navigation now refuses a patch to another member's record before that record is loaded (test sends the forged patch). Release: 1.6.0 (wave 1). Proposed news entry (for the release file once #683 is merged): - Title: Members start on their own data - Sentence: After signing in, members see their own member data with their fees and sign-in settings in the menu, instead of an error message. - Area: Members / self-service - Action needed: no - Link: #665
simon merged commit bdffce99f9 into main 2026-11-13 18:48:05 +01:00
simon deleted branch issue/mitgliederverwaltung-665 2026-11-13 18:48:05 +01:00
Sign in to join this conversation.
No description provided.