Remove the known causes of random red test runs closes #695 #700
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
optional
question
S
security
technical improvement
UX Improvement
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
local-it/mitgliederverwaltung!700
Loading…
Reference in a new issue
No description provided.
Delete branch "issue/mitgliederverwaltung-695"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #695
Description of the implemented changes
The changes were:
Tests: the suite no longer fails at random on a loaded machine for the five known reasons (lost sandbox connection, foreign compile warnings, short waits on background tasks and LiveView patches, whole-table counts).
What has been changed?
Definition of Done
Code Quality
Accessibility
Testing
Additional Notes
ExUnit.start(assert_receive_timeout: 1_000)raises the default wait of everyassert_receive,assert_patchandassert_replyfrom 100 ms to 1 s. A passing test is not slower; a failing one reports up to 1 s later. A member-index patch takes two hops (componentsend(self())→handle_info→push_patch→handle_paramsloads the page), which 100 ms did not always cover.test/mv/repo/sandbox_ownership_test.exsis tagged:slowand sleeps 121 s to prove a test keeps its connection past the 120 s sandbox default. It runs intest-alland in Drone's plainmix test(async, so it overlaps the other async tests).assert_patch/1missed the patch, and the end-to-end join flow, which now sets the join form through the process-local settings override instead of writing the settings row.Mv.Architecture.TestSuiteConventionsTestgets three rules: no standard-error capture in an async module, the default message wait stays at least 1 s, and no literal wait below 1 s.@patch_timeout), "Wait for every background task with the shared timeout" (6 files).just ci-devin a row with 0 test failures while a second full suite ran in parallel, and 3×just test-all.