refactor: reduce nesting depth in process_batch function

1. Fix misleading comment in async create_member path
2. Use skip_lock?: true in test case for create_member
3. Fix generate_cycles_for_all_members/1

lib/membership/custom_field.ex

@@ -12,7 +12,6 @@ defmodule Mv.Membership.CustomField do
   - `slug` - URL-friendly, immutable identifier automatically generated from name (e.g., "phone-mobile")
   - `value_type` - Data type constraint (`:string`, `:integer`, `:boolean`, `:date`, `:email`)
   - `description` - Optional human-readable description
-  - `immutable` - If true, custom field values cannot be changed after creation
   - `required` - If true, all members must have this custom field (future feature)
   - `show_in_overview` - If true, this custom field will be displayed in the member overview table and can be sorted
 
@@ -60,10 +59,10 @@ defmodule Mv.Membership.CustomField do
 
   actions do
     defaults [:read, :update]
-    default_accept [:name, :value_type, :description, :immutable, :required, :show_in_overview]
+    default_accept [:name, :value_type, :description, :required, :show_in_overview]
 
     create :create do
-      accept [:name, :value_type, :description, :immutable, :required, :show_in_overview]
+      accept [:name, :value_type, :description, :required, :show_in_overview]
       change Mv.Membership.CustomField.Changes.GenerateSlug
       validate string_length(:slug, min: 1)
     end
@@ -113,10 +112,6 @@ defmodule Mv.Membership.CustomField do
         trim?: true
       ]
 
-    attribute :immutable, :boolean,
-      default: false,
-      allow_nil?: false
-
     attribute :required, :boolean,
       default: false,
       allow_nil?: false

lib/mv_web/components/core_components.ex

@@ -95,9 +95,11 @@ defmodule MvWeb.CoreComponents do
       <.button>Send!</.button>
       <.button phx-click="go" variant="primary">Send!</.button>
       <.button navigate={~p"/"}>Home</.button>
+      <.button disabled={true}>Disabled</.button>
   """
   attr :rest, :global, include: ~w(href navigate patch method)
   attr :variant, :string, values: ~w(primary)
+  attr :disabled, :boolean, default: false, doc: "Whether the button is disabled"
   slot :inner_block, required: true
 
   def button(%{rest: rest} = assigns) do
@@ -105,14 +107,37 @@ defmodule MvWeb.CoreComponents do
     assigns = assign(assigns, :class, Map.fetch!(variants, assigns[:variant]))
 
     if rest[:href] || rest[:navigate] || rest[:patch] do
+      # For links, we can't use disabled attribute, so we use btn-disabled class
+      # DaisyUI's btn-disabled provides the same styling as :disabled on buttons
+      link_class =
+        if assigns[:disabled],
+          do: ["btn", assigns.class, "btn-disabled"],
+          else: ["btn", assigns.class]
+
+      # Prevent interaction when disabled
+      # Remove navigation attributes to prevent "Open in new tab", "Copy link" etc.
+      link_attrs =
+        if assigns[:disabled] do
+          rest
+          |> Map.drop([:href, :navigate, :patch])
+          |> Map.merge(%{tabindex: "-1", "aria-disabled": "true"})
+        else
+          rest
+        end
+
+      assigns =
+        assigns
+        |> assign(:link_class, link_class)
+        |> assign(:link_attrs, link_attrs)
+
       ~H"""
-      <.link class={["btn", @class]} {@rest}>
+      <.link class={@link_class} {@link_attrs}>
         {render_slot(@inner_block)}
       </.link>
       """
     else
       ~H"""
-      <button class={["btn", @class]} {@rest}>
+      <button class={["btn", @class]} disabled={@disabled} {@rest}>
         {render_slot(@inner_block)}
       </button>
       """

lib/mv_web/components/layouts.ex

@@ -36,12 +36,16 @@ defmodule MvWeb.Layouts do
     default: nil,
     doc: "the current [scope](https://hexdocs.pm/phoenix/scopes.html)"
 
+  attr :club_name, :string,
+    default: nil,
+    doc: "optional club name to pass to navbar"
+
   slot :inner_block, required: true
 
   def app(assigns) do
     ~H"""
     <%= if @current_user do %>
-      <.navbar current_user={@current_user} />
+      <.navbar current_user={@current_user} club_name={@club_name} />
     <% end %>
     <main class="px-4 py-20 sm:px-6 lg:px-16">
       <div class="mx-auto max-full space-y-4">

lib/mv_web/components/layouts/navbar.ex

@@ -12,15 +12,18 @@ defmodule MvWeb.Layouts.Navbar do
     required: true,
     doc: "The current user - navbar is only shown when user is present"
 
-  def navbar(assigns) do
+  attr :club_name, :string,
-    club_name = get_club_name()
+    default: nil,
+    doc: "Optional club name - if not provided, will be loaded from database"
 
+  def navbar(assigns) do
+    club_name = assigns[:club_name] || get_club_name()
     assigns = assign(assigns, :club_name, club_name)
 
     ~H"""
     <header class="navbar bg-base-100 shadow-sm">
       <div class="flex-1">
-        <a class="btn btn-ghost text-xl">{@club_name}</a>
+        <a href="/members" class="btn btn-ghost text-xl">{@club_name}</a>
         <ul class="menu menu-horizontal bg-base-200">
           <li><.link navigate="/members">{gettext("Members")}</.link></li>
           <li><.link navigate="/settings">{gettext("Settings")}</.link></li>

lib/mv_web/live/components/payment_filter_component.ex

@@ -77,7 +77,7 @@ defmodule MvWeb.Components.PaymentFilterComponent do
             phx-target={@myself}
           >
             <.icon name="hero-users" class="h-4 w-4" />
-            {gettext("All")}
+            {gettext("All payment statuses")}
           </button>
         </li>
         <li role="none">
@@ -140,7 +140,7 @@ defmodule MvWeb.Components.PaymentFilterComponent do
   defp parse_filter(_), do: nil
 
   # Get display label for current filter
-  defp filter_label(nil), do: gettext("All")
+  defp filter_label(nil), do: gettext("All payment statuses")
   defp filter_label(:paid), do: gettext("Paid")
   defp filter_label(:not_paid), do: gettext("Not paid")
 end

lib/mv_web/live/custom_field_live/form_component.ex

@@ -6,7 +6,7 @@ defmodule MvWeb.CustomFieldLive.FormComponent do
   - Create new custom field definitions
   - Edit existing custom fields
   - Select value type from supported types
-  - Set immutable and required flags
+  - Set required flag
   - Real-time validation
 
   ## Props
@@ -50,10 +50,10 @@ defmodule MvWeb.CustomFieldLive.FormComponent do
             label={gettext("Value type")}
             options={
               Ash.Resource.Info.attribute(Mv.Membership.CustomField, :value_type).constraints[:one_of]
+              |> Enum.map(fn type -> {MvWeb.Translations.FieldTypes.label(type), type} end)
             }
           />
           <.input field={@form[:description]} type="text" label={gettext("Description")} />
-          <.input field={@form[:immutable]} type="checkbox" label={gettext("Immutable")} />
           <.input field={@form[:required]} type="checkbox" label={gettext("Required")} />
           <.input
             field={@form[:show_in_overview]}
@@ -66,7 +66,7 @@ defmodule MvWeb.CustomFieldLive.FormComponent do
               {gettext("Cancel")}
             </.button>
             <.button phx-disable-with={gettext("Saving...")} variant="primary">
-              {gettext("Save Custom field")}
+              {gettext("Save Custom Field")}
             </.button>
           </div>
         </.form>

lib/mv_web/live/custom_field_live/index_component.ex

@@ -5,7 +5,7 @@ defmodule MvWeb.CustomFieldLive.IndexComponent do
   ## Features
   - List all custom fields
   - Display type information (name, value type, description)
-  - Show immutable and required flags
+  - Show required flag
   - Create new custom fields
   - Edit existing custom fields
   - Delete custom fields with confirmation (cascades to all custom field values)
@@ -30,7 +30,7 @@ defmodule MvWeb.CustomFieldLive.IndexComponent do
               phx-click="new_custom_field"
               phx-target={@myself}
             >
-              <.icon name="hero-plus" /> {gettext("New Custom field")}
+              <.icon name="hero-plus" /> {gettext("New Custom Field")}
             </.button>
           </div>
         </div>

lib/mv_web/live/custom_field_value_live/form.ex

@@ -72,7 +72,7 @@ defmodule MvWeb.CustomFieldValueLive.Form do
         <% end %>
 
         <.button phx-disable-with={gettext("Saving...")} variant="primary">
-          {gettext("Save Custom field value")}
+          {gettext("Save Custom Field Value")}
         </.button>
         <.button navigate={return_path(@return_to, @custom_field_value)}>{gettext("Cancel")}</.button>
       </.form>

lib/mv_web/live/global_settings_live.ex

@@ -37,7 +37,7 @@ defmodule MvWeb.GlobalSettingsLive do
   @impl true
   def render(assigns) do
     ~H"""
-    <Layouts.app flash={@flash} current_user={@current_user}>
+    <Layouts.app flash={@flash} current_user={@current_user} club_name={@settings.club_name}>
       <.header>
         {gettext("Settings")}
         <:subtitle>
@@ -80,10 +80,13 @@ defmodule MvWeb.GlobalSettingsLive do
   @impl true
   def handle_event("save", %{"setting" => setting_params}, socket) do
     case AshPhoenix.Form.submit(socket.assigns.form, params: setting_params) do
-      {:ok, updated_settings} ->
+      {:ok, _updated_settings} ->
+        # Reload settings from database to ensure all dependent data is updated
+        {:ok, fresh_settings} = Membership.get_settings()
+
         socket =
           socket
-          |> assign(:settings, updated_settings)
+          |> assign(:settings, fresh_settings)
           |> put_flash(:info, gettext("Settings updated successfully"))
           |> assign_form()
 

lib/mv_web/live/member_live/index.ex

@@ -145,7 +145,10 @@ defmodule MvWeb.MemberLive.Index do
         MapSet.put(socket.assigns.selected_members, id)
       end
 
-    {:noreply, assign(socket, :selected_members, selected)}
+    {:noreply,
+     socket
+     |> assign(:selected_members, selected)
+     |> update_selection_assigns()}
   end
 
   @impl true
@@ -159,7 +162,10 @@ defmodule MvWeb.MemberLive.Index do
         all_ids
       end
 
-    {:noreply, assign(socket, :selected_members, selected)}
+    {:noreply,
+     socket
+     |> assign(:selected_members, selected)
+     |> update_selection_assigns()}
   end
 
   @impl true
@@ -238,6 +244,7 @@ defmodule MvWeb.MemberLive.Index do
       socket
       |> assign(:query, q)
       |> load_members()
+      |> update_selection_assigns()
 
     existing_field_query = socket.assigns.sort_field
     existing_sort_query = socket.assigns.sort_order
@@ -263,6 +270,7 @@ defmodule MvWeb.MemberLive.Index do
       socket
       |> assign(:paid_filter, filter)
       |> load_members()
+      |> update_selection_assigns()
 
     # Build the URL with all params including new filter
     query_params =
@@ -309,6 +317,7 @@ defmodule MvWeb.MemberLive.Index do
       |> assign(:visible_custom_field_ids, extract_custom_field_ids(visible_custom_fields))
       |> load_members()
       |> prepare_dynamic_cols()
+      |> update_selection_assigns()
       |> push_field_selection_url()
 
     {:noreply, socket}
@@ -338,6 +347,7 @@ defmodule MvWeb.MemberLive.Index do
       |> assign(:visible_custom_field_ids, extract_custom_field_ids(visible_custom_fields))
       |> load_members()
       |> prepare_dynamic_cols()
+      |> update_selection_assigns()
       |> push_field_selection_url()
 
     {:noreply, socket}
@@ -389,6 +399,7 @@ defmodule MvWeb.MemberLive.Index do
       |> assign(:visible_custom_field_ids, extract_custom_field_ids(visible_custom_fields))
       |> load_members()
       |> prepare_dynamic_cols()
+      |> update_selection_assigns()
 
     {:noreply, socket}
   end
@@ -1112,4 +1123,34 @@ defmodule MvWeb.MemberLive.Index do
 
   # Public helper function to format dates for use in templates
   def format_date(date), do: DateFormatter.format_date(date)
+
+  # Updates selection-related assigns (selected_count, any_selected?, mailto_bcc)
+  # to avoid recalculating Enum.any? and Enum.count multiple times in templates.
+  #
+  # Note: Mailto URLs have length limits that vary by email client.
+  # For large selections, consider using export functionality instead.
+  defp update_selection_assigns(socket) do
+    members = socket.assigns.members
+    selected_members = socket.assigns.selected_members
+
+    selected_count =
+      Enum.count(members, &MapSet.member?(selected_members, &1.id))
+
+    any_selected? =
+      Enum.any?(members, &MapSet.member?(selected_members, &1.id))
+
+    mailto_bcc =
+      if any_selected? do
+        format_selected_member_emails(members, selected_members)
+        |> Enum.join(", ")
+        |> URI.encode_www_form()
+      else
+        ""
+      end
+
+    socket
+    |> assign(:selected_count, selected_count)
+    |> assign(:any_selected?, any_selected?)
+    |> assign(:mailto_bcc, mailto_bcc)
+  end
 end

lib/mv_web/live/member_live/index.html.heex

@@ -3,23 +3,21 @@
     {gettext("Members")}
     <:actions>
       <.button
-        :if={Enum.any?(@members, &MapSet.member?(@selected_members, &1.id))}
+        class="secondary"
         id="copy-emails-btn"
         phx-hook="CopyToClipboard"
         phx-click="copy_emails"
+        disabled={not @any_selected?}
         aria-label={gettext("Copy email addresses of selected members")}
       >
         <.icon name="hero-clipboard-document" />
-        {gettext("Copy emails")} ({Enum.count(@members, &MapSet.member?(@selected_members, &1.id))})
+        {gettext("Copy email addresses")} ({@selected_count})
       </.button>
       <.button
-        :if={Enum.any?(@members, &MapSet.member?(@selected_members, &1.id))}
+        class="secondary"
-        href={
+        id="open-email-btn"
-          "mailto:?bcc=" <>
+        href={"mailto:?bcc=" <> @mailto_bcc}
-          (MvWeb.MemberLive.Index.format_selected_member_emails(@members, @selected_members)
+        disabled={not @any_selected?}
-           |> Enum.join(", ")
-           |> URI.encode())
-        }
         aria-label={gettext("Open email program with BCC recipients")}
       >
         <.icon name="hero-envelope" />

priv/gettext/de/LC_MESSAGES/default.po

@@ -282,11 +282,6 @@ msgstr "Benutzer*in bearbeiten"
 msgid "Enabled"
 msgstr "Aktiviert"
 
-#: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format
-msgid "Immutable"
-msgstr "Unveränderlich"
-
 #: lib/mv_web/components/layouts/navbar.ex
 #, elixir-autogen, elixir-format
 msgid "Logout"
@@ -612,16 +607,6 @@ msgstr "Benutzerdefinierter Feldwert erfolgreich %{action}"
 msgid "Please select a custom field first"
 msgstr "Bitte wähle zuerst ein Benutzerdefiniertes Feld"
 
-#: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format
-msgid "Save Custom field"
-msgstr "Benutzerdefiniertes Feld speichern"
-
-#: lib/mv_web/live/custom_field_value_live/form.ex
-#, elixir-autogen, elixir-format
-msgid "Save Custom field value"
-msgstr "Benutzerdefinierten Feldwert speichern"
-
 #: lib/mv_web/live/custom_field_live/index_component.ex
 #: lib/mv_web/live/member_live/form.ex
 #: lib/mv_web/live/member_live/show.ex
@@ -760,11 +745,6 @@ msgstr[1] "%{count} E-Mail-Adressen in die Zwischenablage kopiert"
 msgid "Copy email addresses of selected members"
 msgstr "E-Mail-Adressen der ausgewählten Mitglieder kopieren"
 
-#: lib/mv_web/live/member_live/index.html.heex
-#, elixir-autogen, elixir-format
-msgid "Copy emails"
-msgstr "E-Mails kopieren"
-
 #: lib/mv_web/live/member_live/index.ex
 #, elixir-autogen, elixir-format
 msgid "No email addresses found"
@@ -796,7 +776,6 @@ msgid "This field cannot be empty"
 msgstr "Dieses Feld darf nicht leer bleiben"
 
 #: lib/mv_web/components/core_components.ex
-#: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All"
 msgstr "Alle"
@@ -1302,14 +1281,10 @@ msgid "Failed to delete custom field: %{error}"
 msgstr "Konnte Feld nicht löschen: %{error}"
 
 #: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format, fuzzy
-msgid "New Custom Field"
-msgstr "Benutzerdefiniertes Feld speichern"
-
 #: lib/mv_web/live/custom_field_live/index_component.ex
 #, elixir-autogen, elixir-format, fuzzy
-msgid "New Custom field"
+msgid "New Custom Field"
-msgstr "Benutzerdefiniertes Feld speichern"
+msgstr "Neues Benutzerdefiniertes Feld"
 
 #: lib/mv_web/live/global_settings_live.ex
 #, elixir-autogen, elixir-format
@@ -1427,6 +1402,31 @@ msgstr "Jährliches Intervall – Beitrittszeitraum nicht einbezogen"
 msgid "Yearly Interval - Joining Cycle Included"
 msgstr "Jährliches Intervall – Beitrittszeitraum einbezogen"
 
+#: lib/mv_web/live/components/payment_filter_component.ex
+#, elixir-autogen, elixir-format
+msgid "All payment statuses"
+msgstr "Jeder Zahlungs-Zustand"
+
+#: lib/mv_web/live/member_live/index.html.heex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Copy email addresses"
+msgstr "E-Mail-Adressen kopieren"
+
+#: lib/mv_web/live/custom_field_live/form_component.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Save Custom Field"
+msgstr "Benutzerdefiniertes Feld speichern"
+
+#: lib/mv_web/live/custom_field_value_live/form.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Save Custom Field Value"
+msgstr "Benutzerdefinierten Feldwert speichern"
+
+#~ #: lib/mv_web/live/custom_field_live/show.ex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Auto-generated identifier (immutable)"
+#~ msgstr "Automatisch generierter Bezeichner (unveränderlich)"
+
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Configure global settings for membership contributions."
@@ -1443,6 +1443,17 @@ msgstr "Jährliches Intervall – Beitrittszeitraum einbezogen"
 #~ msgid "Contribution start"
 #~ msgstr "Beitragsbeginn"
 
+#~ #: lib/mv_web/live/member_live/index.html.heex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Copy emails"
+#~ msgstr "E-Mails kopieren"
+
+#~ #: lib/mv_web/live/member_live/form.ex
+#~ #: lib/mv_web/live/member_live/show.ex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Custom Field Values"
+#~ msgstr "Benutzerdefinierte Feldwerte"
+
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Default Contribution Type"
@@ -1463,6 +1474,11 @@ msgstr "Jährliches Intervall – Beitrittszeitraum einbezogen"
 #~ msgid "Generated periods"
 #~ msgstr "Generierte Zyklen"
 
+#~ #: lib/mv_web/live/custom_field_live/form_component.ex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Immutable"
+#~ msgstr "Unveränderlich"
+
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Include joining period"
@@ -1473,6 +1489,17 @@ msgstr "Jährliches Intervall – Beitrittszeitraum einbezogen"
 #~ msgid "Monthly Interval - Joining Period Included"
 #~ msgstr "Monatliches Intervall – Beitrittszeitraum einbezogen"
 
+#~ #: lib/mv_web/live/custom_field_live/index_component.ex
+#~ #, elixir-autogen, elixir-format, fuzzy
+#~ msgid "New Custom field"
+#~ msgstr "Benutzerdefiniertes Feld speichern"
+
+#~ #: lib/mv_web/live/user_live/form.ex
+#~ #: lib/mv_web/live/user_live/show.ex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Not set"
+#~ msgstr "Nicht gesetzt"
+
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Quarterly Interval - Joining Period Excluded"

priv/gettext/default.pot

@@ -283,11 +283,6 @@ msgstr ""
 msgid "Enabled"
 msgstr ""
 
-#: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format
-msgid "Immutable"
-msgstr ""
-
 #: lib/mv_web/components/layouts/navbar.ex
 #, elixir-autogen, elixir-format
 msgid "Logout"
@@ -613,16 +608,6 @@ msgstr ""
 msgid "Please select a custom field first"
 msgstr ""
 
-#: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format
-msgid "Save Custom field"
-msgstr ""
-
-#: lib/mv_web/live/custom_field_value_live/form.ex
-#, elixir-autogen, elixir-format
-msgid "Save Custom field value"
-msgstr ""
-
 #: lib/mv_web/live/custom_field_live/index_component.ex
 #: lib/mv_web/live/member_live/form.ex
 #: lib/mv_web/live/member_live/show.ex
@@ -761,11 +746,6 @@ msgstr[1] ""
 msgid "Copy email addresses of selected members"
 msgstr ""
 
-#: lib/mv_web/live/member_live/index.html.heex
-#, elixir-autogen, elixir-format
-msgid "Copy emails"
-msgstr ""
-
 #: lib/mv_web/live/member_live/index.ex
 #, elixir-autogen, elixir-format
 msgid "No email addresses found"
@@ -797,7 +777,6 @@ msgid "This field cannot be empty"
 msgstr ""
 
 #: lib/mv_web/components/core_components.ex
-#: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All"
 msgstr ""
@@ -1303,13 +1282,9 @@ msgid "Failed to delete custom field: %{error}"
 msgstr ""
 
 #: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format
-msgid "New Custom Field"
-msgstr ""
-
 #: lib/mv_web/live/custom_field_live/index_component.ex
 #, elixir-autogen, elixir-format
-msgid "New Custom field"
+msgid "New Custom Field"
 msgstr ""
 
 #: lib/mv_web/live/global_settings_live.ex
@@ -1427,3 +1402,23 @@ msgstr ""
 #, elixir-autogen, elixir-format
 msgid "Yearly Interval - Joining Cycle Included"
 msgstr ""
+
+#: lib/mv_web/live/components/payment_filter_component.ex
+#, elixir-autogen, elixir-format
+msgid "All payment statuses"
+msgstr ""
+
+#: lib/mv_web/live/member_live/index.html.heex
+#, elixir-autogen, elixir-format
+msgid "Copy email addresses"
+msgstr ""
+
+#: lib/mv_web/live/custom_field_live/form_component.ex
+#, elixir-autogen, elixir-format
+msgid "Save Custom Field"
+msgstr ""
+
+#: lib/mv_web/live/custom_field_value_live/form.ex
+#, elixir-autogen, elixir-format
+msgid "Save Custom Field Value"
+msgstr ""

priv/gettext/en/LC_MESSAGES/default.po

@@ -283,11 +283,6 @@ msgstr ""
 msgid "Enabled"
 msgstr ""
 
-#: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format
-msgid "Immutable"
-msgstr ""
-
 #: lib/mv_web/components/layouts/navbar.ex
 #, elixir-autogen, elixir-format
 msgid "Logout"
@@ -613,16 +608,6 @@ msgstr ""
 msgid "Please select a custom field first"
 msgstr ""
 
-#: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format
-msgid "Save Custom field"
-msgstr ""
-
-#: lib/mv_web/live/custom_field_value_live/form.ex
-#, elixir-autogen, elixir-format
-msgid "Save Custom field value"
-msgstr ""
-
 #: lib/mv_web/live/custom_field_live/index_component.ex
 #: lib/mv_web/live/member_live/form.ex
 #: lib/mv_web/live/member_live/show.ex
@@ -761,11 +746,6 @@ msgstr[1] ""
 msgid "Copy email addresses of selected members"
 msgstr ""
 
-#: lib/mv_web/live/member_live/index.html.heex
-#, elixir-autogen, elixir-format
-msgid "Copy emails"
-msgstr ""
-
 #: lib/mv_web/live/member_live/index.ex
 #, elixir-autogen, elixir-format
 msgid "No email addresses found"
@@ -797,7 +777,6 @@ msgid "This field cannot be empty"
 msgstr ""
 
 #: lib/mv_web/components/core_components.ex
-#: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All"
 msgstr ""
@@ -1303,13 +1282,9 @@ msgid "Failed to delete custom field: %{error}"
 msgstr ""
 
 #: lib/mv_web/live/custom_field_live/form_component.ex
-#, elixir-autogen, elixir-format, fuzzy
-msgid "New Custom Field"
-msgstr ""
-
 #: lib/mv_web/live/custom_field_live/index_component.ex
 #, elixir-autogen, elixir-format, fuzzy
-msgid "New Custom field"
+msgid "New Custom Field"
 msgstr ""
 
 #: lib/mv_web/live/global_settings_live.ex
@@ -1428,7 +1403,27 @@ msgstr ""
 msgid "Yearly Interval - Joining Cycle Included"
 msgstr ""
 
-#~ #: lib/mv_web/live/contribution_settings_live.ex
+#: lib/mv_web/live/components/payment_filter_component.ex
+#, elixir-autogen, elixir-format
+msgid "All payment statuses"
+msgstr ""
+
+#: lib/mv_web/live/member_live/index.html.heex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Copy email addresses"
+msgstr ""
+
+#: lib/mv_web/live/custom_field_live/form_component.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Save Custom Field"
+msgstr ""
+
+#: lib/mv_web/live/custom_field_value_live/form.ex
+#, elixir-autogen, elixir-format, fuzzy
+msgid "Save Custom Field Value"
+msgstr ""
+
+#~ #: lib/mv_web/live/custom_field_live/show.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Configure global settings for membership contributions."
 #~ msgstr ""
@@ -1439,11 +1434,18 @@ msgstr ""
 #~ msgid "Contribution Settings"
 #~ msgstr ""
 
-#~ #: lib/mv_web/live/contribution_settings_live.ex
+#~ #: lib/mv_web/live/member_live/form.ex
+#~ #: lib/mv_web/live/member_live/show.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Contribution start"
 #~ msgstr ""
 
+#~ #: lib/mv_web/live/contribution_settings_live.ex
+#~ #: lib/mv_web/live/member_live/index.html.heex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Copy emails"
+#~ msgstr ""
+
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Default Contribution Type"
@@ -1459,11 +1461,18 @@ msgstr ""
 #~ msgid "Failed to save settings. Please check the errors below."
 #~ msgstr ""
 
-#~ #: lib/mv_web/live/contribution_settings_live.ex
+#~ #: lib/mv_web/live/user_live/index.html.heex
+#~ #: lib/mv_web/live/user_live/show.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Generated periods"
 #~ msgstr ""
 
+#~ #: lib/mv_web/live/contribution_settings_live.ex
+#~ #: lib/mv_web/live/custom_field_live/form_component.ex
+#~ #, elixir-autogen, elixir-format
+#~ msgid "Immutable"
+#~ msgstr ""
+
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Include joining period"
@@ -1474,6 +1483,16 @@ msgstr ""
 #~ msgid "Monthly Interval - Joining Period Included"
 #~ msgstr ""
 
+#~ #: lib/mv_web/live/custom_field_live/index_component.ex
+#~ #, elixir-autogen, elixir-format, fuzzy
+#~ msgid "New Custom field"
+#~ msgstr ""
+
+#~ #: lib/mv_web/live/user_live/show.ex
+#~ #, elixir-autogen, elixir-format, fuzzy
+#~ msgid "Not set"
+#~ msgstr ""
+
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Quarterly Interval - Joining Period Excluded"

priv/repo/migrations/20251211172549_remove_immutable_from_custom_fields.exs

@@ -0,0 +1,21 @@
+defmodule Mv.Repo.Migrations.RemoveImmutableFromCustomFields do
+  @moduledoc """
+  Removes the immutable column from custom_fields table.
+
+  The immutable field is no longer needed in the custom field definition.
+  """
+
+  use Ecto.Migration
+
+  def up do
+    alter table(:custom_fields) do
+      remove :immutable
+    end
+  end
+
+  def down do
+    alter table(:custom_fields) do
+      add :immutable, :boolean, null: false, default: false
+    end
+  end
+end

priv/repo/seeds.exs

@@ -45,28 +45,24 @@ for attrs <- [
         name: "String Field",
         value_type: :string,
         description: "Example for a field of type string",
-        immutable: true,
         required: false
       },
       %{
         name: "Date Field",
         value_type: :date,
         description: "Example for a field of type date",
-        immutable: true,
         required: false
       },
       %{
         name: "Boolean Field",
         value_type: :boolean,
         description: "Example for a field of type boolean",
-        immutable: true,
         required: false
       },
       %{
         name: "Email Field",
         value_type: :email,
         description: "Example for a field of type email",
-        immutable: true,
         required: false
       },
       # Realistic custom fields
@@ -74,56 +70,48 @@ for attrs <- [
         name: "Membership Number",
         value_type: :string,
         description: "Unique membership identification number",
-        immutable: false,
         required: false
       },
       %{
         name: "Emergency Contact",
         value_type: :string,
         description: "Emergency contact person name and phone",
-        immutable: false,
         required: false
       },
       %{
         name: "T-Shirt Size",
         value_type: :string,
         description: "T-Shirt size for events (XS, S, M, L, XL, XXL)",
-        immutable: false,
         required: false
       },
       %{
         name: "Newsletter Subscription",
         value_type: :boolean,
         description: "Whether member wants to receive newsletter",
-        immutable: false,
         required: false
       },
       %{
         name: "Date of Last Medical Check",
         value_type: :date,
         description: "Date of last medical examination",
-        immutable: false,
         required: false
       },
       %{
         name: "Secondary Email",
         value_type: :email,
         description: "Alternative email address",
-        immutable: false,
         required: false
       },
       %{
         name: "Membership Type",
         value_type: :string,
         description: "Type of membership (e.g., Regular, Student, Senior)",
-        immutable: false,
         required: false
       },
       %{
         name: "Parking Permit",
         value_type: :boolean,
         description: "Whether member has parking permit",
-        immutable: false,
         required: false
       }
     ] do

test/mv_web/member_live/index_custom_fields_accessibility_test.exs

@@ -52,14 +52,11 @@ defmodule MvWeb.MemberLive.IndexCustomFieldsAccessibilityTest do
     field: field
   } do
     conn = conn_with_oidc_user(conn)
-    {:ok, _view, html} = live(conn, "/members")
+    {:ok, view, _html} = live(conn, "/members")
 
-    # Check that the sort button has aria-label
+    # Check that the sort button has aria-label and data-testid
-    assert html =~ ~r/aria-label=["']Click to sort["']/i or
+    test_id = "custom_field_#{field.id}"
-             html =~ ~r/aria-label=["'].*sort.*["']/i
+    assert has_element?(view, "[data-testid='#{test_id}'][aria-label='Click to sort']")
-
-    # Check that data-testid is present for testing
-    assert html =~ ~r/data-testid=["']custom_field_#{field.id}["']/
   end
 
   test "sort header component shows correct ARIA label when sorted ascending", %{
@@ -71,10 +68,9 @@ defmodule MvWeb.MemberLive.IndexCustomFieldsAccessibilityTest do
     {:ok, view, _html} =
       live(conn, "/members?query=&sort_field=custom_field_#{field.id}&sort_order=asc")
 
-    html = render(view)
+    # Check that aria-label indicates ascending sort using data-testid
-
+    test_id = "custom_field_#{field.id}"
-    # Check that aria-label indicates ascending sort
+    assert has_element?(view, "[data-testid='#{test_id}'][aria-label='ascending']")
-    assert html =~ ~r/aria-label=["'].*ascending.*["']/i
   end
 
   test "sort header component shows correct ARIA label when sorted descending", %{
@@ -86,21 +82,21 @@ defmodule MvWeb.MemberLive.IndexCustomFieldsAccessibilityTest do
     {:ok, view, _html} =
       live(conn, "/members?query=&sort_field=custom_field_#{field.id}&sort_order=desc")
 
-    html = render(view)
+    # Check that aria-label indicates descending sort using data-testid
-
+    test_id = "custom_field_#{field.id}"
-    # Check that aria-label indicates descending sort
+    assert has_element?(view, "[data-testid='#{test_id}'][aria-label='descending']")
-    assert html =~ ~r/aria-label=["'].*descending.*["']/i
   end
 
   test "custom field column header is keyboard accessible", %{conn: conn, field: field} do
     conn = conn_with_oidc_user(conn)
-    {:ok, _view, html} = live(conn, "/members")
+    {:ok, view, _html} = live(conn, "/members")
 
     # Check that the sort button is a button element (keyboard accessible)
-    assert html =~ ~r/<button[^>]*data-testid=["']custom_field_#{field.id}["']/
+    test_id = "custom_field_#{field.id}"
+    assert has_element?(view, "button[data-testid='#{test_id}']")
 
     # Button should not have tabindex="-1" (which would remove from tab order)
-    refute html =~ ~r/tabindex=["']-1["']/
+    refute has_element?(view, "button[data-testid='#{test_id}'][tabindex='-1']")
   end
 
   test "custom field column header has proper semantic structure", %{conn: conn, field: field} do

test/mv_web/member_live/index_test.exs

@@ -410,15 +410,17 @@ defmodule MvWeb.MemberLive.IndexTest do
       assert render(view) =~ "1"
     end
 
-    test "copy button is not visible when no members are selected", %{conn: conn} do
+    test "copy button is disabled when no members selected", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
       {:ok, view, _html} = live(conn, "/members")
 
-      # Ensure no members are selected (default state)
+      # Copy button should be disabled (button element)
-      refute has_element?(view, "#copy-emails-btn")
+      assert has_element?(view, "#copy-emails-btn[disabled]")
+      # Open email button should be disabled (link with tabindex and aria-disabled)
+      assert has_element?(view, "#open-email-btn[tabindex='-1'][aria-disabled='true']")
     end
 
-    test "copy button is visible when members are selected", %{
+    test "copy button is enabled after selection", %{
       conn: conn,
       member1: member1
     } do
@@ -428,8 +430,13 @@ defmodule MvWeb.MemberLive.IndexTest do
       # Select a member by sending the select_member event directly
       render_click(view, "select_member", %{"id" => member1.id})
 
-      # Button should now be visible
+      # Copy button should now be enabled (no disabled attribute)
-      assert has_element?(view, "#copy-emails-btn")
+      refute has_element?(view, "#copy-emails-btn[disabled]")
+      # Open email button should now be enabled (no tabindex=-1 or aria-disabled)
+      refute has_element?(view, "#open-email-btn[tabindex='-1']")
+      refute has_element?(view, "#open-email-btn[aria-disabled='true']")
+      # Counter should show correct count
+      assert render(view) =~ "1"
     end
 
     test "copy button click triggers event and shows flash", %{