local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

Link to userdate from profile button closes #170 #173

Merged
simon merged 15 commits from 170-userdata-for-profile-button into main 2025-10-16 12:23:28 +02:00
Conversation 2 Commits 15 Files changed 27 +1257 -65
simon commented 2025-09-29 16:29:49 +02:00
Owner
Copy link

Description of the implemented changes

The changes were:

  • Bugfixing
  • New Feature
  • Breaking Change
  • Refactoring

Set the link for the "profile" button. This led to every view needing the current_user, resulting in a little refactoring of the the layout handling. This was done to make the current_user requirement explicit in authenticated views.

Also edited the test helper functions to allow for multiple tests creating users with the same function

What has been changed?

  • passed current user in all views
  • Navbar is only shown when current_user is present

Definition of Done

Code Quality

  • No new technical depths
  • Linting passed
  • Documentation is added were needed

Accessibility

  • New elements are properly defined with html-tags
  • Colour contrast follows WCAG criteria
  • Aria labels are added when needed
  • Everything is accessible by keyboard
  • Tab-Order is comprehensible
  • All interactive elements have a visible focus

Testing

  • Tests for new code are written
  • All tests pass
  • axe-core dev tools show no critical or major issues

Additional Notes

  • Added @tag :skip for avatar initials tests - topic for discussion and later implementation
  • Other questions arose - should users be reference by uuid in the url - or have a unique username?
    • see: http://localhost:4000/users/0dc6439e-b193-4d8b-b2b1-dadd8b23d946
  • Later, users should probably get their own detail view on their user profile details, distinct from that one admins use to manage the user details
## Description of the implemented changes The changes were: - [ ] Bugfixing - [x] New Feature - [ ] Breaking Change - [x] Refactoring <!--- Describe the goal of the PR in a few words --> Set the link for the "profile" button. This led to every view needing the `current_user`, resulting in a little refactoring of the the layout handling. This was done to make the current_user requirement explicit in authenticated views. Also edited the test helper functions to allow for multiple tests creating users with the same function ## What has been changed? - passed `current user` in all views - Navbar is only shown when current_user is present ## Definition of Done ### Code Quality - [x] No new technical depths - [x] Linting passed - [x] Documentation is added were needed ### Accessibility - [x] New elements are properly defined with html-tags - [x] Colour contrast follows WCAG criteria - [x] Aria labels are added when needed - [x] Everything is accessible by keyboard - [x] Tab-Order is comprehensible - [x] All interactive elements have a visible focus ### Testing - [x] Tests for new code are written - [x] All tests pass - [x] axe-core dev tools show no critical or major issues ## Additional Notes - Added @tag :skip for avatar initials tests - topic for discussion and later implementation - Other questions arose - should users be reference by uuid in the url - or have a unique username? - see: `http://localhost:4000/users/0dc6439e-b193-4d8b-b2b1-dadd8b23d946` - Later, users should probably get their own detail view on their user profile details, distinct from that one admins use to manage the user details
simon added 4 commits 2025-09-29 16:29:50 +02:00
test: fix tests and skip tests for initials generation
Some checks failed
continuous-integration/drone/push Build is failing
Details
863821f3ae
Merge remote-tracking branch 'origin/main' into 170-userdata-for-profile-button
Some checks failed
continuous-integration/drone/push Build is failing
Details
d40bc0bb82
simon added 1 commit 2025-09-29 16:42:32 +02:00
style: fix linting errors
Some checks failed
continuous-integration/drone/push Build is failing
Details
d10fcc3da1
simon added 1 commit 2025-09-29 16:59:50 +02:00
fix: add missing user for view and fix test
Some checks failed
continuous-integration/drone/push Build is failing
Details
1d334c7da1
simon changed title from WIP: Link to userdate from profile button closes #170 to Link to userdate from profile button closes #170 2025-09-29 17:15:41 +02:00
requested reviews from moritz, carla, rafael 2025-09-29 17:15:49 +02:00
carla approved these changes 2025-10-01 09:42:06 +02:00
carla left a comment
Owner
Copy link

Nice work :)
Just the linting / Todo thing.. but then approved :)

Nice work :) Just the linting / Todo thing.. but then approved :)
lib/mv_web/components/layouts.ex
@ -23,2 +24,4 @@
</Layout.app>
<Layouts.app flash={@flash} current_user={@current_user}>
<h1>Authenticated Content</h1>
carla commented 2025-10-01 08:47:47 +02:00
Owner
Copy link

I know the h1 tag was there before, but I actually do not get when its rendered. Do you know? Because if its an h1 tag which says authenticated content we should maybe change it but if its not rendered we could also omit?

I know the h1 tag was there before, but I actually do not get when its rendered. Do you know? Because if its an h1 tag which says authenticated content we should maybe change it but if its not rendered we could also omit?
rafael commented 2025-10-13 17:55:13 +02:00
Collaborator
Copy link

I'm not sure if that's the case with you but for me, the forgejo review UI confused me a bit. I found out that this code is part of an example in a documentation comment, so the h1 you're referring to will never get really rendered, it's just a placeholder to illustrate the functionality.

I'm not sure if that's the case with you but for me, the forgejo review UI confused me a bit. I found out that this code is part of an example in a documentation comment, so the h1 you're referring to will never get really rendered, it's just a placeholder to illustrate the functionality.
simon marked this conversation as resolved
test/mv_web/components/layouts/navbar_test.exs
@ -0,0 +23,4 @@
end
@tag :skip
# TODO: Implement user initials in navbar avatar - see issue #170
carla commented 2025-10-01 08:32:47 +02:00
Owner
Copy link

Just a minor thing but: Lint is not passing with TODO s :/

Just a minor thing but: Lint is not passing with TODO s :/
simon added this to the Sprint 7 - 02.10 - 23.10. project 2025-10-02 13:14:48 +02:00
simon removed this from the Sprint 7 - 02.10 - 23.10. project 2025-10-02 13:16:08 +02:00
rafael approved these changes 2025-10-13 18:01:42 +02:00
rafael left a comment
Collaborator
Copy link

Nice!

Nice!
lib/mv_web/live/member_live/show.ex
@ -6,3 +6,3 @@
def render(assigns) do
~H"""
<Layouts.app flash={@flash}>
<Layouts.app flash={@flash} current_user={@current_user}>
rafael commented 2025-10-13 17:59:13 +02:00
Collaborator
Copy link

As a future possibility (outside of this PR), we could try Phoenix's new scopes feature for this.

As a future possibility (outside of this PR), we could try Phoenix's [new scopes feature](https://hexdocs.pm/phoenix/scopes.html) for this.
simon added 8 commits 2025-10-16 12:07:50 +02:00
Fix error when deleting members
Some checks failed
continuous-integration/drone/push Build is failing
Details
96c5b956e5
simon added 1 commit 2025-10-16 12:13:54 +02:00
chore: disable linter breaking for TODOs
Some checks failed
continuous-integration/drone/push Build is failing
Details
8d3b76b954
simon merged commit ce9878791e into main 2025-10-16 12:23:28 +02:00
simon deleted branch 170-userdata-for-profile-button 2025-10-16 12:23:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
moritz
carla
rafael
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
high priority

   
invalid

Something is wrong

  
L

5 h

  
low priority

   
M

3 h

  
medium priority

   
needs refinement

   
question

More information is needed

  
S

1 h

  
UX research

   
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
high priority
invalid
L
low priority
M
medium priority
needs refinement
question
S
UX research
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: local-it/mitgliederverwaltung#173
No description provided.
Delete branch "170-userdata-for-profile-button"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?