refactor: reduce nesting depth in process_batch function

fix: address notification handling review feedback
1. Fix misleading comment in async create_member path 2. Use skip_lock?: true in test case for create_member 3. Fix generate_cycles_for_all_members/1
2025-12-18 15:00:45 +01:00 · 2025-12-18 15:00:45 +01:00 · 2025-12-18 15:00:44 +01:00 · 2025-12-18 15:00:44 +01:00 · 2025-12-18 15:00:44 +01:00 · 2025-12-18 15:00:44 +01:00
3 changed files with 73 additions and 66 deletions
--- a/priv/gettext/de/LC_MESSAGES/default.po
+++ b/priv/gettext/de/LC_MESSAGES/default.po
@ -1326,6 +1326,26 @@ msgstr "Textfeld"
 msgid "Yes/No-Selection"
 msgstr "Ja/Nein-Auswahl"
 #: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All payment statuses"
 msgstr "Jeder Zahlungs-Zustand"
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Copy email addresses"
 msgstr "E-Mail-Adressen kopieren"
 #: lib/mv_web/live/custom_field_live/form_component.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Save Custom Field"
 msgstr "Benutzerdefiniertes Feld speichern"
 #: lib/mv_web/live/custom_field_value_live/form.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Save Custom Field Value"
 msgstr "Benutzerdefinierten Feldwert speichern"
 #: lib/mv_web/live/membership_fee_settings_live.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Configure global settings for membership fees."
@ -1402,26 +1422,6 @@ msgstr "Jährliches Intervall – Beitrittszeitraum nicht einbezogen"
 msgid "Yearly Interval - Joining Cycle Included"
 msgstr "Jährliches Intervall – Beitrittszeitraum einbezogen"
 #: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All payment statuses"
 msgstr "Jeder Zahlungs-Zustand"
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Copy email addresses"
 msgstr "E-Mail-Adressen kopieren"
 #: lib/mv_web/live/custom_field_live/form_component.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Save Custom Field"
 msgstr "Benutzerdefiniertes Feld speichern"
 #: lib/mv_web/live/custom_field_value_live/form.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Save Custom Field Value"
 msgstr "Benutzerdefinierten Feldwert speichern"
 #~ #: lib/mv_web/live/custom_field_live/show.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Auto-generated identifier (immutable)"
--- a/priv/gettext/default.pot
+++ b/priv/gettext/default.pot
@ -1327,6 +1327,26 @@ msgstr ""
 msgid "Yes/No-Selection"
 msgstr ""
 #: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All payment statuses"
 msgstr ""
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format
 msgid "Copy email addresses"
 msgstr ""
 #: lib/mv_web/live/custom_field_live/form_component.ex
 #, elixir-autogen, elixir-format
 msgid "Save Custom Field"
 msgstr ""
 #: lib/mv_web/live/custom_field_value_live/form.ex
 #, elixir-autogen, elixir-format
 msgid "Save Custom Field Value"
 msgstr ""
 #: lib/mv_web/live/membership_fee_settings_live.ex
 #, elixir-autogen, elixir-format
 msgid "Configure global settings for membership fees."
@ -1402,23 +1422,3 @@ msgstr ""
 #, elixir-autogen, elixir-format
 msgid "Yearly Interval - Joining Cycle Included"
 msgstr ""
 #: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All payment statuses"
 msgstr ""
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format
 msgid "Copy email addresses"
 msgstr ""
 #: lib/mv_web/live/custom_field_live/form_component.ex
 #, elixir-autogen, elixir-format
 msgid "Save Custom Field"
 msgstr ""
 #: lib/mv_web/live/custom_field_value_live/form.ex
 #, elixir-autogen, elixir-format
 msgid "Save Custom Field Value"
 msgstr ""
--- a/priv/gettext/en/LC_MESSAGES/default.po
+++ b/priv/gettext/en/LC_MESSAGES/default.po
@ -1327,6 +1327,26 @@ msgstr ""
 msgid "Yes/No-Selection"
 msgstr ""
 #: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All payment statuses"
 msgstr ""
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Copy email addresses"
 msgstr ""
 #: lib/mv_web/live/custom_field_live/form_component.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Save Custom Field"
 msgstr ""
 #: lib/mv_web/live/custom_field_value_live/form.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Save Custom Field Value"
 msgstr ""
 #: lib/mv_web/live/membership_fee_settings_live.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Configure global settings for membership fees."
@ -1403,28 +1423,13 @@ msgstr ""
 msgid "Yearly Interval - Joining Cycle Included"
 msgstr ""
 #: lib/mv_web/live/components/payment_filter_component.ex
 #, elixir-autogen, elixir-format
 msgid "All payment statuses"
 msgstr ""
 #: lib/mv_web/live/member_live/index.html.heex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Copy email addresses"
 msgstr ""
 #: lib/mv_web/live/custom_field_live/form_component.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Save Custom Field"
 msgstr ""
 #: lib/mv_web/live/custom_field_value_live/form.ex
 #, elixir-autogen, elixir-format, fuzzy
 msgid "Save Custom Field Value"
 msgstr ""
 #~ #: lib/mv_web/live/custom_field_live/show.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Auto-generated identifier (immutable)"
 #~ msgstr ""
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Configure global settings for membership contributions."
 #~ msgstr ""
@ -1434,18 +1439,22 @@ msgstr ""
 #~ msgid "Contribution Settings"
 #~ msgstr ""
-#~ #: lib/mv_web/live/member_live/form.ex
+#~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #: lib/mv_web/live/member_live/show.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Contribution start"
 #~ msgstr ""
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #: lib/mv_web/live/member_live/index.html.heex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Copy emails"
 #~ msgstr ""
 #~ #: lib/mv_web/live/member_live/form.ex
 #~ #: lib/mv_web/live/member_live/show.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Custom Field Values"
 #~ msgstr ""
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Default Contribution Type"
@ -1461,13 +1470,11 @@ msgstr ""
 #~ msgid "Failed to save settings. Please check the errors below."
 #~ msgstr ""
-#~ #: lib/mv_web/live/user_live/index.html.heex
+#~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #: lib/mv_web/live/user_live/show.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Generated periods"
 #~ msgstr ""
 #~ #: lib/mv_web/live/contribution_settings_live.ex
 #~ #: lib/mv_web/live/custom_field_live/form_component.ex
 #~ #, elixir-autogen, elixir-format
 #~ msgid "Immutable"
Author	SHA1	Message	Date
Moritz	017ee5bc0c	refactor: reduce nesting depth in process_batch function All checks were successful continuous-integration/drone/push Build is passing Details	2025-12-18 15:00:45 +01:00
Moritz	d720670fd2	fix: address notification handling review feedback 1. Fix misleading comment in async create_member path 2. Use skip_lock?: true in test case for create_member 3. Fix generate_cycles_for_all_members/1	2025-12-18 15:00:45 +01:00
Moritz	c25ffdc034	refactor: implement proper notification handling via after_action hooks Refactor notification handling according to Ash best practices	2025-12-18 15:00:44 +01:00
Moritz	98b56fc406	fix: resolve notification handling and maintain after_action for cycle regeneration	2025-12-18 15:00:44 +01:00
Moritz	ba0ece9dc6	fix: correct return_notifications? logic to prevent missed notifications Fix the logic for return_notifications? in create_cycles	2025-12-18 15:00:44 +01:00
Moritz	0783a2fe18	refactor: reduce nesting depth in regenerate_cycles_on_type_change Split the function into smaller, focused functions to reduce nesting depth	2025-12-18 15:00:44 +01:00
Moritz	66d0c9a702	fix: address code review points for cycle regeneration 1. Fix critical notifications bug 2. Fix today inconsistency 3. Add advisory lock around deletion 4. Improve helper function documentation 5. Improve error message UX	2025-12-18 15:00:44 +01:00
Moritz	6158602598	refactor: reduce complexity of with_advisory_lock function Split the complex with_advisory_lock function into smaller, focused functions to improve readability and reduce cyclomatic complexity	2025-12-18 15:00:43 +01:00
Moritz	d8e9c157bf	fix: prevent deadlocks by detecting existing transactions	2025-12-18 15:00:43 +01:00
Moritz	9d7d06d430	test: update test to reflect nil assignment prevention	2025-12-18 15:00:43 +01:00
Moritz	70e673034a	fix: remove unused variable warning in ValidateSameInterval	2025-12-18 15:00:43 +01:00
Moritz	4867bb9470	docs: update architecture docs for atomic cycle regeneration	2025-12-18 15:00:43 +01:00
Moritz	094ed857ed	test: add monthly interval tests for cycle calculations	2025-12-18 15:00:42 +01:00
Moritz	9c18be61a8	test: remove Process.sleep from type change integration tests	2025-12-18 15:00:42 +01:00
Moritz	0e8f492800	fix: prevent nil assignment for membership_fee_type_id Reject attempts to set membership_fee_type_id to nil when a current type exists.	2025-12-18 15:00:42 +01:00
Moritz	6183fc6978	fix: implement fail-closed behavior in ValidateSameInterval Change validation to fail closed instead of fail open when types cannot be loaded. This prevents inconsistent data states and provides clearer error messages to users.	2025-12-18 15:00:42 +01:00
Moritz	69c9746974	fix: make cycle regeneration atomic on type change Make cycle regeneration synchronous in the same transaction as the member update to ensure atomicity.	2025-12-18 15:00:42 +01:00
Moritz	f6e2ecd74b	refactor: reduce nesting depth and improve code readability - Replace Enum.map \|> Enum.join with Enum.map_join for efficiency - Extract helper functions to reduce nesting depth from 4 to 2 - Rename is_current_cycle? to current_cycle? following Elixir conventions	2025-12-18 15:00:41 +01:00
Moritz	b9fb115eb5	feat: regenerate cycles when membership fee type changes (same interval) - Implemented regenerate_cycles_on_type_change helper in Member resource - Cycles that haven't ended yet (cycle_end >= today) are deleted and regenerated - Paid and suspended cycles remain unchanged (not deleted) - CycleGenerator reloads member with new membership_fee_type_id - Adjusted tests to work with current cycles only (no future cycles) - All integration tests passing Phase 4 completed: Cycle regeneration on type change	2025-12-18 15:00:41 +01:00
Moritz	3177ea20dd	feat: add validation for same-interval membership fee type changes	2025-12-18 15:00:41 +01:00
Moritz	43ec281242	feat: add cycle status calculations to Member resource	2025-12-18 15:00:41 +01:00
Moritz	910a91aa74	feat: add status management actions to MembershipFeeCycle	2025-12-18 15:00:41 +01:00
moritz	ac786662b1	Merge pull request 'Membership Fee Type Resource & Settings closes #278 ' (#291 ) from feature/278_membership_fee_settings into main All checks were successful continuous-integration/drone/push Build is passing Details Reviewed-on: #291	2025-12-18 14:17:09 +01:00
Moritz	d75e2b7a46	feat: add 4 example membership fee types to seed script All checks were successful continuous-integration/drone/push Build is passing Details	2025-12-18 11:54:23 +01:00
Moritz	820ead3429	chore: update gettext	2025-12-18 11:54:23 +01:00
Moritz	f0e1d3fade	docs: document require_atomic? false in MembershipFeeType actions	2025-12-18 11:54:23 +01:00
Moritz	78b5335456	refactor: migrate MembershipFeeSettingsLive to AshPhoenix.Form	2025-12-18 11:54:23 +01:00
Moritz	511f52fba8	feat: improve error handling in settings validation for default_membership_fee_type_id	2025-12-18 11:54:23 +01:00
Moritz	4813d6080b	feat: prevent deletion of membership fee type when used as default in settings	2025-12-18 11:54:23 +01:00
Moritz	97bba4c218	refactor: use Enum.map_join instead of Enum.map \|> Enum.join	2025-12-18 11:54:23 +01:00
Moritz	283f824f4d	fix: improve accessibility - WCAG 2 AA contrast and select label	2025-12-18 11:54:23 +01:00
Moritz	630b51ac34	refactor: replace ContributionSettingsLive mockup with MembershipFeeSettingsLive in navigation	2025-12-18 11:54:23 +01:00
Moritz	f7d23ee7fe	i18n: add German translations for membership fee settings	2025-12-18 11:54:23 +01:00
Moritz	e135a6cdbf	feat: implement full CRUD for membership fee types with settings UI - Add interval immutability and deletion prevention validations - Add settings validation for default_membership_fee_type_id - Create MembershipFeeSettingsLive for admin UI with form handling - Add comprehensive test coverage (unit, integration, settings)	2025-12-18 11:54:23 +01:00
moritz	ff39448fd6	Merge pull request 'Cycle Generation System closes #277 ' (#290 ) from feature/277_cycle_generation into main All checks were successful continuous-integration/drone/push Build is passing Details Reviewed-on: #290 Reviewed-by: carla <carla@noreply.git.local-it.org>	2025-12-18 11:53:10 +01:00
Moritz	ed083830b9	refactor: improve cycle generation code quality and documentation All checks were successful continuous-integration/drone/push Build is passing Details - Remove Process.sleep calls from integration tests (tests run synchronously in SQL sandbox) - Improve error handling: membership_fee_type_not_found now returns changeset error instead of just logging - Clarify partial_failure documentation: successful_cycles are not persisted on rollback - Update documentation: joined_at → join_date, left_at → exit_date - Document PostgreSQL advisory locks per member (not whole table lock) - Document gap handling: explicitly deleted cycles are not recreated	2025-12-16 16:40:11 +01:00
Moritz	62a2bd41ea	fix: handle Ash notifications in CycleGenerator transactions - Use return_notifications?: true when creating cycles within transaction - Collect notifications and send them after transaction commits - Prevents 'Missed notifications' warnings in test output - Notifications are now properly sent via Ash.Notifier.notify/1	2025-12-16 16:40:11 +01:00
Moritz	d9ca6b1763	test: fix date dependencies in cycle generator tests - Add create_member_with_cycles helper that uses fixed 'today' date - Update tests to use explicit 'today:' option instead of Date.utc_today() - Prevents test failures when current date changes (e.g., in 2026+) - Tests now explicitly delete and regenerate cycles with fixed dates - Ensures consistent test behavior regardless of execution date	2025-12-16 16:40:11 +01:00
Moritz	de7a94ab07	fix: CycleGenerator generates from last cycle, not filling gaps - Change algorithm to start from last existing cycle instead of start_date - Deleted cycles (gaps) are no longer automatically filled - Add test to verify gaps remain unfilled - Update documentation to clarify gap handling behavior	2025-12-16 16:40:11 +01:00
Moritz	539084fdf1	test: make CycleGenerator tests more robust - Replace weak assertions (>= 0, if length > 0) with concrete expectations - Remove unnecessary Process.sleep calls (tests run synchronously) - Add get_member_cycles helper for direct cycle verification - Tests now validate actual generated cycles instead of relying on async behavior	2025-12-16 16:40:11 +01:00
Moritz	13790dda43	feat: improve error handling in CycleGenerator - Handle Task crashes in async_stream with {:exit, reason} - Return {:error, {:partial_failure, successes, errors}} when some cycles fail - Previously returned {:ok, successful} even on partial failures - Improves debuggability and allows callers to handle partial failures	2025-12-16 16:40:11 +01:00
Moritz	d01033c720	feat: include inactive members in batch cycle generation - Remove exit_date filter from generate_cycles_for_all_members query - Inactive members now get cycles generated up to their exit_date - Add tests for inactive member processing and exit_date boundary - Document exit_date == cycle_start behavior (cycle still generated)	2025-12-16 16:40:11 +01:00
Moritz	78747d7da0	refactor: improve SetMembershipFeeStartDate change module - Add warning logging for unexpected errors (not missing prerequisites) - Use CalendarCycles.interval() type instead of generic atom() - Update moduledoc to reflect actual usage (no where clause needed)	2025-12-16 16:40:11 +01:00
Moritz	e899004b3c	feat: add error logging in after_action cycle generation hooks - Log warnings when cycle generation fails in Member create/update - Extract generate_fn to reduce code duplication - Improves debuggability of silent failures	2025-12-16 16:40:11 +01:00
Moritz	434bcd269f	refactor: use sql_sandbox config instead of env for sync/async - Replace Application.get_env(:mv, :env) with :sql_sandbox config - Remove redundant :env config from test.exs - More explicit and less error-prone for test environment detection	2025-12-16 16:40:11 +01:00
Moritz	25cc41b02e	feat: implement automatic cycle generation for members - Add CycleGenerator module with advisory lock mechanism - Add SetMembershipFeeStartDate change for auto-calculation - Extend Settings with include_joining_cycle and default_membership_fee_type_id - Add scheduled job skeleton for future Oban integration	2025-12-16 16:40:11 +01:00
moritz	894b9b9d5c	Merge pull request 'Calendar Cycle Calculation Logic closes #276 ' (#284 ) from feature/276_cycle_calculation into main All checks were successful continuous-integration/drone/push Build is passing Details Reviewed-on: #284 Reviewed-by: carla <carla@noreply.git.local-it.org>	2025-12-16 16:39:35 +01:00
Moritz	a7285915e6	docs: fix CalendarCycles documentation to match actual implementation All checks were successful continuous-integration/drone/push Build is passing Details	2025-12-16 15:06:45 +01:00
Moritz	da6c495d04	refactor: improve CalendarCycles API and tests based on code review	2025-12-16 15:06:45 +01:00
Moritz	3fc4440bce	feat: implement calendar-based cycle calculation functions Add CalendarCycles module with functions for all interval types. Includes comprehensive tests for edge cases.	2025-12-16 15:06:45 +01:00